You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ki...@apache.org on 2022/05/06 07:12:46 UTC

[commons-imaging] branch master updated (dbbe2b9d -> 0349d97f)

This is an automated email from the ASF dual-hosted git repository.

kinow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git


    from dbbe2b9d Set permissions for GH Actions
     new 9d5603a6 Bump spotbugs from 4.6.0 to 4.7.0
     new 0349d97f SpotBugs: Throw a IllegalArgumentException instead of a RuntimeException (as in other methods)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 pom.xml                                               | 2 +-
 src/changes/changes.xml                               | 2 +-
 src/main/java/org/apache/commons/imaging/Imaging.java | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)


[commons-imaging] 01/02: Bump spotbugs from 4.6.0 to 4.7.0

Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git

commit 9d5603a62dd95e003c206fe62d9622e74c7bf260
Author: dependabot[bot] <49...@users.noreply.github.com>
AuthorDate: Thu May 5 17:10:15 2022 +0000

    Bump spotbugs from 4.6.0 to 4.7.0
    
    Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.6.0 to 4.7.0.
    - [Release notes](https://github.com/spotbugs/spotbugs/releases)
    - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/spotbugs/spotbugs/compare/4.6.0...4.7.0)
    
    ---
    updated-dependencies:
    - dependency-name: com.github.spotbugs:spotbugs
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <su...@github.com>
---
 pom.xml                 | 2 +-
 src/changes/changes.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 9e2da37b..2179ae05 100644
--- a/pom.xml
+++ b/pom.xml
@@ -57,7 +57,7 @@
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <checkstyle.plugin.version>3.1.2</checkstyle.plugin.version>
     <spotbugs.plugin.version>4.6.0.0</spotbugs.plugin.version>
-    <spotbugs.impl.version>4.6.0</spotbugs.impl.version>
+    <spotbugs.impl.version>4.7.0</spotbugs.impl.version>
 
     <!-- Commons Release Plugin -->
     <commons.bc.version>1.0-alpha1</commons.bc.version>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 54f657f6..32c2306a 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -89,7 +89,7 @@ The <action> type attribute can be add,update,fix,remove.
         Bump maven-checkstyle-plugin from 3.1.1 to 3.1.2 #117.
       </action>
       <action dev="kinow" type="update" due-to="Dependabot">
-        Bump spotbugs from 4.0.6 to 4.6.0 #111 #118 #123 #128 #156 #160 #167 #174 #185 #188 #191 #208.
+        Bump spotbugs from 4.0.6 to 4.7.0 #111 #118 #123 #128 #156 #160 #167 #174 #185 #188 #191 #208 #218.
       </action>
       <action dev="kinow" type="update" due-to="Dependabot">
         Bump spotbugs-maven-plugin from 4.0.4 to 4.6.0.0 #111 #115 #125 #129 #157 #171 #176 #180 #186 #192 #211.


[commons-imaging] 02/02: SpotBugs: Throw a IllegalArgumentException instead of a RuntimeException (as in other methods)

Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git

commit 0349d97fb06a2f7af11d1832076dddcd7e841ccc
Author: Bruno P. Kinoshita <ki...@apache.org>
AuthorDate: Fri May 6 19:00:08 2022 +1200

    SpotBugs: Throw a IllegalArgumentException instead of a RuntimeException (as in other methods)
---
 src/main/java/org/apache/commons/imaging/Imaging.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/imaging/Imaging.java b/src/main/java/org/apache/commons/imaging/Imaging.java
index a992603d..339f3c1a 100644
--- a/src/main/java/org/apache/commons/imaging/Imaging.java
+++ b/src/main/java/org/apache/commons/imaging/Imaging.java
@@ -185,7 +185,7 @@ public final class Imaging {
 
     private static boolean compareBytePair(final int[] a, final int[] b) {
         if (a.length != 2 && b.length != 2) {
-            throw new RuntimeException("Invalid Byte Pair.");
+            throw new IllegalArgumentException("Invalid Byte Pair.");
         }
         return (a[0] == b[0]) && (a[1] == b[1]);
     }