You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/01 07:31:14 UTC
[GitHub] apeforest commented on a change in pull request #14287: FIX: flaky
test exponential generator
apeforest commented on a change in pull request #14287: FIX: flaky test exponential generator
URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261502101
##########
File path: python/mxnet/test_utils.py
##########
@@ -1933,7 +1933,7 @@ def chi_square_check(generator, buckets, probs, nsamples=1000000):
_, p = ss.chisquare(f_obs=obs_freq, f_exp=expected_freq)
return p, obs_freq, expected_freq
-def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5, success_rate=0.25, alpha=0.05):
+def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5, success_rate=0.15, alpha=0.05):
Review comment:
@access2rohit Please make the change as you commented: make 0.25 as default and pass in 0.15 for exponential generator check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services