You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Sergey Vladimirov (JIRA)" <ji...@apache.org> on 2010/06/13 20:00:24 UTC

[jira] Created: (FTPSERVER-378) [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)

[FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)
---------------------------------------------------------------------------------------------------------------------------------------------

                 Key: FTPSERVER-378
                 URL: https://issues.apache.org/jira/browse/FTPSERVER-378
             Project: FtpServer
          Issue Type: Bug
          Components: Core
            Reporter: Sergey Vladimirov
            Priority: Minor
             Fix For: WISHLIST


If session.getRemoteAddress() is not instanceof InetSocketAddress, then address is null. But UserLogins do not accept nulls as argument (null can't be a key for ConcurrentHashMap)

I think 'fake' NULL address constant shall be introduced in DefaultFtpStatistics for this case.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FTPSERVER-378) [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson updated FTPSERVER-378:
----------------------------------------

    Fix Version/s: 1.0.6
                       (was: 1.1.0)
                       (was: 1.0.5)

> [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-378
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-378
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: 1.0.6
>
>
> If session.getRemoteAddress() is not instanceof InetSocketAddress, then address is null. But UserLogins do not accept nulls as argument (null can't be a key for ConcurrentHashMap)
> I think 'fake' NULL address constant shall be introduced in DefaultFtpStatistics for this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FTPSERVER-378) [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson updated FTPSERVER-378:
----------------------------------------

    Fix Version/s: 1.0.5
                   1.1.0
                       (was: WISHLIST)

> [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-378
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-378
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: 1.0.5, 1.1.0
>
>
> If session.getRemoteAddress() is not instanceof InetSocketAddress, then address is null. But UserLogins do not accept nulls as argument (null can't be a key for ConcurrentHashMap)
> I think 'fake' NULL address constant shall be introduced in DefaultFtpStatistics for this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FTPSERVER-378) [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson updated FTPSERVER-378:
----------------------------------------

    Fix Version/s: 1.1.0

> [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-378
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-378
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: 1.0.6, 1.1.0
>
>
> If session.getRemoteAddress() is not instanceof InetSocketAddress, then address is null. But UserLogins do not accept nulls as argument (null can't be a key for ConcurrentHashMap)
> I think 'fake' NULL address constant shall be introduced in DefaultFtpStatistics for this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.