You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/25 11:28:31 UTC

[GitHub] [flink] twalthr opened a new pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

twalthr opened a new pull request #13480:
URL: https://github.com/apache/flink/pull/13480


   ## What is the purpose of the change
   
   This updates all API related classes to support the concept of a
   metadata column. It considers all location until planner level.
   
   ## Brief change log
   
   - Update `TableColumn` to a hierarchy of 3 column types
   - Update TableSchemaUtils and all related locations that rely on computed column but have to deal with metadata column now as well.
   
   ## Verifying this change
   
   This change is already covered by existing tests. Plus `DescriptorPropertiesTest`, `MergeLikeUtilTest`, and others.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     }, {
       "hash" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 382e46040d85bbed2df63d12698a8475d890ec35 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959) 
   * 99b6ed8ddda677809737efedaad44110f57ee551 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 382e46040d85bbed2df63d12698a8475d890ec35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 382e46040d85bbed2df63d12698a8475d890ec35 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     }, {
       "hash" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7121",
       "triggerID" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 382e46040d85bbed2df63d12698a8475d890ec35 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959) 
   * 99b6ed8ddda677809737efedaad44110f57ee551 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7121) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 382e46040d85bbed2df63d12698a8475d890ec35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698878283






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13480:
URL: https://github.com/apache/flink/pull/13480#discussion_r497368371



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java
##########
@@ -84,21 +84,21 @@ public static TableSchema projectSchema(TableSchema tableSchema, int[][] project
 	}
 
 	/**
-	 * Returns true if there are any generated columns in the given {@link TableColumn}.
+	 * Returns true if there are only physical columns in the given {@link TableSchema}.
 	 */
-	public static boolean containsGeneratedColumns(TableSchema schema) {
+	public static boolean containsPhysicalColumnsOnly(TableSchema schema) {
 		Preconditions.checkNotNull(schema);
-		return schema.getTableColumns().stream().anyMatch(TableColumn::isGenerated);
+		return schema.getTableColumns().stream().allMatch(TableColumn::isPhysical);
 	}
 
 	/**
-	 * Throws exception if the given {@link TableSchema} contains any generated columns.
+	 * Throws an exception if the given {@link TableSchema} contains any non-physical columns.
 	 */
-	public static TableSchema checkNoGeneratedColumns(TableSchema schema) {
+	public static TableSchema checkPhysicalColumns(TableSchema schema) {

Review comment:
       I think `verifyOnlyPhysicalColumns()` or sth like it would be better. As it is, it sounds like the method will just check all physical columns.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     }, {
       "hash" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7121",
       "triggerID" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 99b6ed8ddda677809737efedaad44110f57ee551 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7121) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr closed pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #13480:
URL: https://github.com/apache/flink/pull/13480


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     }, {
       "hash" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7121",
       "triggerID" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41ffcb8482d31ab5e637a587981259d29f984d04",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7333",
       "triggerID" : "41ffcb8482d31ab5e637a587981259d29f984d04",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa497eb8dbc0271613bfd12aca6e887a04fc6535",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aa497eb8dbc0271613bfd12aca6e887a04fc6535",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 41ffcb8482d31ab5e637a587981259d29f984d04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7333) 
   * aa497eb8dbc0271613bfd12aca6e887a04fc6535 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 382e46040d85bbed2df63d12698a8475d890ec35 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     }, {
       "hash" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7121",
       "triggerID" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41ffcb8482d31ab5e637a587981259d29f984d04",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7333",
       "triggerID" : "41ffcb8482d31ab5e637a587981259d29f984d04",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa497eb8dbc0271613bfd12aca6e887a04fc6535",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7424",
       "triggerID" : "aa497eb8dbc0271613bfd12aca6e887a04fc6535",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 41ffcb8482d31ab5e637a587981259d29f984d04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7333) 
   * aa497eb8dbc0271613bfd12aca6e887a04fc6535 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7424) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698886630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6959",
       "triggerID" : "382e46040d85bbed2df63d12698a8475d890ec35",
       "triggerType" : "PUSH"
     }, {
       "hash" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7121",
       "triggerID" : "99b6ed8ddda677809737efedaad44110f57ee551",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41ffcb8482d31ab5e637a587981259d29f984d04",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7333",
       "triggerID" : "41ffcb8482d31ab5e637a587981259d29f984d04",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 41ffcb8482d31ab5e637a587981259d29f984d04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7333) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13480: [FLINK-19341][table] Update all API related methods to FLIP-107

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13480:
URL: https://github.com/apache/flink/pull/13480#issuecomment-698878283


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 382e46040d85bbed2df63d12698a8475d890ec35 (Fri Sep 25 11:30:59 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org