You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/12 22:58:47 UTC
[GitHub] [couchdb] jjrodrig opened a new pull request #2660: Port elixir
proxyauth tests from js to elixir
jjrodrig opened a new pull request #2660: Port elixir proxyauth tests from js to elixir
URL: https://github.com/apache/couchdb/pull/2660
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
This PR ports the proxyauth tests from js to elixir. This test was disabled in the js test suite.
The proxy_authentication_handler should be enabled at startup as the changes on chttpd.authentication_handlers config property is not hot-reloaded by CouchDB. An option has ben added to the dev/run script in order to specify a config file to be placed at etc/local.d folder.
Makefile for elixir target now includes a custom config file that enables all the auth handlers for testing.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
```
make elixir tests=test/elixir/test/proxyauth_test.exs
```
for checking new dev/run option:
```
dev/run -n 1 --locald-config test/elixir/test/config/test-config.ini
```
should place the test-config.ini file at dev/lib/node1/etc/local.d folder
## Related Issues or Pull Requests
This PR allows to #2648 to include integration tests for the new JWT auth handler
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [X] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] jjrodrig merged pull request #2660: Port elixir proxyauth
tests from js to elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #2660: Port elixir proxyauth tests from js to elixir
URL: https://github.com/apache/couchdb/pull/2660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] rnewson commented on issue #2660: Port elixir proxyauth
tests from js to elixir
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #2660: Port elixir proxyauth tests from js to elixir
URL: https://github.com/apache/couchdb/pull/2660#issuecomment-599606912
and with a merge from master too 🤦♂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] rnewson commented on issue #2660: Port elixir proxyauth
tests from js to elixir
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #2660: Port elixir proxyauth tests from js to elixir
URL: https://github.com/apache/couchdb/pull/2660#issuecomment-599606722
this should not have merged with so many lines of whitespace only change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services