You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Ovidiu Predescu <ov...@cup.hp.com> on 2001/10/01 18:40:38 UTC
Re: [patch] improved esql.xsl
Torsten,
I looked at your patch, and although I'm not very familiar with the
esql logicsheet, your changes seem to be in the right direction. I
would give a +1 to them (note I'm not a committer ;-).
One improvement you can probably make is to pool the EsqlConnection
objects, so you can obtain even better performance. This may be tricky
to do though, as each connection might be connected using a different
user account. These are only some thoughts, it doesn't mean you have
to implement them now.
Ovidiu
PS: BTW, anybody knows what happened to Donald?
On Mon, 01 Oct 2001 10:58:31 +0200, Torsten Curdt <tc...@dff.st> wrote:
> could someone *PLEASE* have a look?
> Thanks
> --
> Torsten
>
> > It has been pretty quite around Donald (Donald, are you still out
> > there ;) Christian, maybe you could have a look?
> >
> > We have had no problem within any old esql page so far.
> > But we can only test it with one database (sybase ASA).
> >
> > Thanks
> > --
> > Torsten
> >
> > > -----Original Message-----
> > > From: Carsten Ziegeler [mailto:cziegeler@sundn.de]
> > > Sent: Friday, September 28, 2001 8:12 AM
> > > To: Cocoon-Dev@Xml. Apache. Org
> > > Subject: AW: [patch] improved esql.xsl
> > >
> > >
> > > Hi Team,
> > >
> > > could someone with more knowledge of eqsl than me
> > > look at this patch, please?
> > >
> > > Carsten
> > >
> > > > -----Ursprungliche Nachricht-----
> > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > Gesendet: Donnerstag, 27. September 2001 11:39
> > > > An: Carsten Ziegeler
> > > > Cc: cocoon-dev@xml.apache.org
> > > > Betreff: Re: AW: [patch] improved esql.xsl
> > > >
> > > >
> > > > recreated it from the current CVS so it should be fine.
> > > > Thanks
> > > > --
> > > > Torsten
> > > >
> > > > > Hi Torsten,
> > > > >
> > > > > it looks like your patch is still not applied.
> > > > > Could you please test if it works and then
> > > > > resend the patch, so we can apply it?
> > > > >
> > > > > Carsten
> > > > >
> > > > > > -----Ursprungliche Nachricht-----
> > > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > > Gesendet: Freitag, 21. September 2001 14:08
> > > > > > An: cocoon-dev@xml.apache.org
> > > > > > Betreff: RE: [patch] improved esql.xsl
> > > > > >
> > > > > >
> > > > > > Are there any objections on this one?
> > > > > > --
> > > > > > Torsten
> > > > > >
> > > > > > > I straightened out the latest esql.xsl logicsheet
> > > > > > >
> > > > > > > - removed the inner classes (created real ones)
> > > > > > > - moved redundant code into a helper class
> > > > > > > - added support for jdbc ResultSet positioning
> > > > > > > (now we can do paging not only for MySQL and PostgreSQL
> > > > > > > and it's quite easy to add more)
> > > > > > > - added a <esql:previous-results> as counterpart of
> > > > > > <esql:more-results>
> > > > > > >
> > > > > > > Everything else should be same as before.
> > > > > > >
> > > > > > > I could not test this thoroughly but it would be
> > > > > > > great if someone could apply this to the current head branch.
> > > > > > >
> > > > > > > Thanks
> > > > > > > --
> > > > > > > Torsten
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
Re: [patch] improved esql.xsl
Posted by Berin Loritsch <bl...@apache.org>.
Ovidiu Predescu wrote:
>
> Torsten,
>
> I looked at your patch, and although I'm not very familiar with the
> esql logicsheet, your changes seem to be in the right direction. I
> would give a +1 to them (note I'm not a committer ;-).
>
> One improvement you can probably make is to pool the EsqlConnection
> objects, so you can obtain even better performance. This may be tricky
> to do though, as each connection might be connected using a different
> user account. These are only some thoughts, it doesn't mean you have
> to implement them now.
Connection pooling is done by the mechanisms set up for whichever Cocoon
version you are using. Cocoon 1 uses Turbine pooling, and Cocoon 2+ uses
Avalon pooling.
Beyond that, don't worry about it.
>
> Ovidiu
>
> PS: BTW, anybody knows what happened to Donald?
>
> On Mon, 01 Oct 2001 10:58:31 +0200, Torsten Curdt <tc...@dff.st> wrote:
>
> > could someone *PLEASE* have a look?
> > Thanks
> > --
> > Torsten
> >
> > > It has been pretty quite around Donald (Donald, are you still out
> > > there ;) Christian, maybe you could have a look?
> > >
> > > We have had no problem within any old esql page so far.
> > > But we can only test it with one database (sybase ASA).
> > >
> > > Thanks
> > > --
> > > Torsten
> > >
> > > > -----Original Message-----
> > > > From: Carsten Ziegeler [mailto:cziegeler@sundn.de]
> > > > Sent: Friday, September 28, 2001 8:12 AM
> > > > To: Cocoon-Dev@Xml. Apache. Org
> > > > Subject: AW: [patch] improved esql.xsl
> > > >
> > > >
> > > > Hi Team,
> > > >
> > > > could someone with more knowledge of eqsl than me
> > > > look at this patch, please?
> > > >
> > > > Carsten
> > > >
> > > > > -----Ursprungliche Nachricht-----
> > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > Gesendet: Donnerstag, 27. September 2001 11:39
> > > > > An: Carsten Ziegeler
> > > > > Cc: cocoon-dev@xml.apache.org
> > > > > Betreff: Re: AW: [patch] improved esql.xsl
> > > > >
> > > > >
> > > > > recreated it from the current CVS so it should be fine.
> > > > > Thanks
> > > > > --
> > > > > Torsten
> > > > >
> > > > > > Hi Torsten,
> > > > > >
> > > > > > it looks like your patch is still not applied.
> > > > > > Could you please test if it works and then
> > > > > > resend the patch, so we can apply it?
> > > > > >
> > > > > > Carsten
> > > > > >
> > > > > > > -----Ursprungliche Nachricht-----
> > > > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > > > Gesendet: Freitag, 21. September 2001 14:08
> > > > > > > An: cocoon-dev@xml.apache.org
> > > > > > > Betreff: RE: [patch] improved esql.xsl
> > > > > > >
> > > > > > >
> > > > > > > Are there any objections on this one?
> > > > > > > --
> > > > > > > Torsten
> > > > > > >
> > > > > > > > I straightened out the latest esql.xsl logicsheet
> > > > > > > >
> > > > > > > > - removed the inner classes (created real ones)
> > > > > > > > - moved redundant code into a helper class
> > > > > > > > - added support for jdbc ResultSet positioning
> > > > > > > > (now we can do paging not only for MySQL and PostgreSQL
> > > > > > > > and it's quite easy to add more)
> > > > > > > > - added a <esql:previous-results> as counterpart of
> > > > > > > <esql:more-results>
> > > > > > > >
> > > > > > > > Everything else should be same as before.
> > > > > > > >
> > > > > > > > I could not test this thoroughly but it would be
> > > > > > > > great if someone could apply this to the current head branch.
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > > --
> > > > > > > > Torsten
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [patch] improved esql.xsl
Posted by Torsten Curdt <tc...@dff.st>.
> Torsten,
>
> I looked at your patch, and although I'm not very familiar with the
> esql logicsheet, your changes seem to be in the right direction. I
> would give a +1 to them (note I'm not a committer ;-).
Thanks, Ovidiu.
I'm not sure if I want to bug Donald off the list.
(I did so before ;)
Is there really no other committer familiar enough to
say if this patch is ok!?
> One improvement you can probably make is to pool the EsqlConnection
> objects, so you can obtain even better performance. This may be tricky
> to do though, as each connection might be connected using a different
> user account. These are only some thoughts, it doesn't mean you have
> to implement them now.
The SQLConnections are already pooled. The EsqlConnections were introduced
by Donald to have more convenient access to all related variables.
> Ovidiu
>
> PS: BTW, anybody knows what happened to Donald?
He must be alright. I meet him on the resin list ;)
>
> On Mon, 01 Oct 2001 10:58:31 +0200, Torsten Curdt <tc...@dff.st> wrote:
>
> > could someone *PLEASE* have a look?
> > Thanks
> > --
> > Torsten
> >
> > > It has been pretty quite around Donald (Donald, are you still out
> > > there ;) Christian, maybe you could have a look?
> > >
> > > We have had no problem within any old esql page so far.
> > > But we can only test it with one database (sybase ASA).
> > >
> > > Thanks
> > > --
> > > Torsten
> > >
> > > > -----Original Message-----
> > > > From: Carsten Ziegeler [mailto:cziegeler@sundn.de]
> > > > Sent: Friday, September 28, 2001 8:12 AM
> > > > To: Cocoon-Dev@Xml. Apache. Org
> > > > Subject: AW: [patch] improved esql.xsl
> > > >
> > > >
> > > > Hi Team,
> > > >
> > > > could someone with more knowledge of eqsl than me
> > > > look at this patch, please?
> > > >
> > > > Carsten
> > > >
> > > > > -----Ursprungliche Nachricht-----
> > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > Gesendet: Donnerstag, 27. September 2001 11:39
> > > > > An: Carsten Ziegeler
> > > > > Cc: cocoon-dev@xml.apache.org
> > > > > Betreff: Re: AW: [patch] improved esql.xsl
> > > > >
> > > > >
> > > > > recreated it from the current CVS so it should be fine.
> > > > > Thanks
> > > > > --
> > > > > Torsten
> > > > >
> > > > > > Hi Torsten,
> > > > > >
> > > > > > it looks like your patch is still not applied.
> > > > > > Could you please test if it works and then
> > > > > > resend the patch, so we can apply it?
> > > > > >
> > > > > > Carsten
> > > > > >
> > > > > > > -----Ursprungliche Nachricht-----
> > > > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > > > Gesendet: Freitag, 21. September 2001 14:08
> > > > > > > An: cocoon-dev@xml.apache.org
> > > > > > > Betreff: RE: [patch] improved esql.xsl
> > > > > > >
> > > > > > >
> > > > > > > Are there any objections on this one?
> > > > > > > --
> > > > > > > Torsten
> > > > > > >
> > > > > > > > I straightened out the latest esql.xsl logicsheet
> > > > > > > >
> > > > > > > > - removed the inner classes (created real ones)
> > > > > > > > - moved redundant code into a helper class
> > > > > > > > - added support for jdbc ResultSet positioning
> > > > > > > > (now we can do paging not only for MySQL and PostgreSQL
> > > > > > > > and it's quite easy to add more)
> > > > > > > > - added a <esql:previous-results> as counterpart of
> > > > > > > <esql:more-results>
> > > > > > > >
> > > > > > > > Everything else should be same as before.
> > > > > > > >
> > > > > > > > I could not test this thoroughly but it would be
> > > > > > > > great if someone could apply this to the current head branch.
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > > --
> > > > > > > > Torsten
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [patch] improved esql.xsl
Posted by Torsten Curdt <tc...@dff.st>.
...this should't stop us from developing a bit further, shouldn't it?!
I don't know if sub cvs is really a good idea. Why not applying new
things only to the HEAD branch. That's 2 commits: C1 HEAD and C2 HEAD.
That's about it.
--
Torsten
> -----Original Message-----
> From: John Morrison [mailto:john.r.morrison@ntlworld.com]
> Sent: Monday, October 01, 2001 7:04 PM
> To: cocoon-dev@xml.apache.org
> Subject: RE: [patch] improved esql.xsl
>
>
> Donald is busy at work with non-cocoon projects. I've been having a chat
> with him offlist and he hopes to be back soon. (He didn't say when).
>
> The main problem with esql (as far as I'm concerned) is that there are _FAR_
> too many copies of it (C1 + all its branches, C2 + all its (two ;)
> branches). Could we do something about shared tag libraries (sub cvs
> repository ala Apache httpd2)?
>
> J.
>
> > -----Original Message-----
> > From: ovidiu@cup.hp.com [mailto:ovidiu@cup.hp.com]
> > Sent: Monday, 01 October 2001 5:41 pm
> > To: Torsten Curdt; Carsten Ziegeler
> > Cc: cocoon-dev@xml.apache.org
> > Subject: Re: [patch] improved esql.xsl
> >
> >
> > Torsten,
> >
> > I looked at your patch, and although I'm not very familiar with the
> > esql logicsheet, your changes seem to be in the right direction. I
> > would give a +1 to them (note I'm not a committer ;-).
> >
> > One improvement you can probably make is to pool the EsqlConnection
> > objects, so you can obtain even better performance. This may be tricky
> > to do though, as each connection might be connected using a different
> > user account. These are only some thoughts, it doesn't mean you have
> > to implement them now.
> >
> > Ovidiu
> >
> > PS: BTW, anybody knows what happened to Donald?
> >
> > On Mon, 01 Oct 2001 10:58:31 +0200, Torsten Curdt <tc...@dff.st> wrote:
> >
> > > could someone *PLEASE* have a look?
> > > Thanks
> > > --
> > > Torsten
> > >
> > > > It has been pretty quite around Donald (Donald, are you still out
> > > > there ;) Christian, maybe you could have a look?
> > > >
> > > > We have had no problem within any old esql page so far.
> > > > But we can only test it with one database (sybase ASA).
> > > >
> > > > Thanks
> > > > --
> > > > Torsten
> > > >
> > > > > -----Original Message-----
> > > > > From: Carsten Ziegeler [mailto:cziegeler@sundn.de]
> > > > > Sent: Friday, September 28, 2001 8:12 AM
> > > > > To: Cocoon-Dev@Xml. Apache. Org
> > > > > Subject: AW: [patch] improved esql.xsl
> > > > >
> > > > >
> > > > > Hi Team,
> > > > >
> > > > > could someone with more knowledge of eqsl than me
> > > > > look at this patch, please?
> > > > >
> > > > > Carsten
> > > > >
> > > > > > -----Ursprungliche Nachricht-----
> > > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > > Gesendet: Donnerstag, 27. September 2001 11:39
> > > > > > An: Carsten Ziegeler
> > > > > > Cc: cocoon-dev@xml.apache.org
> > > > > > Betreff: Re: AW: [patch] improved esql.xsl
> > > > > >
> > > > > >
> > > > > > recreated it from the current CVS so it should be fine.
> > > > > > Thanks
> > > > > > --
> > > > > > Torsten
> > > > > >
> > > > > > > Hi Torsten,
> > > > > > >
> > > > > > > it looks like your patch is still not applied.
> > > > > > > Could you please test if it works and then
> > > > > > > resend the patch, so we can apply it?
> > > > > > >
> > > > > > > Carsten
> > > > > > >
> > > > > > > > -----Ursprungliche Nachricht-----
> > > > > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > > > > Gesendet: Freitag, 21. September 2001 14:08
> > > > > > > > An: cocoon-dev@xml.apache.org
> > > > > > > > Betreff: RE: [patch] improved esql.xsl
> > > > > > > >
> > > > > > > >
> > > > > > > > Are there any objections on this one?
> > > > > > > > --
> > > > > > > > Torsten
> > > > > > > >
> > > > > > > > > I straightened out the latest esql.xsl logicsheet
> > > > > > > > >
> > > > > > > > > - removed the inner classes (created real ones)
> > > > > > > > > - moved redundant code into a helper class
> > > > > > > > > - added support for jdbc ResultSet positioning
> > > > > > > > > (now we can do paging not only for MySQL and PostgreSQL
> > > > > > > > > and it's quite easy to add more)
> > > > > > > > > - added a <esql:previous-results> as counterpart of
> > > > > > > > <esql:more-results>
> > > > > > > > >
> > > > > > > > > Everything else should be same as before.
> > > > > > > > >
> > > > > > > > > I could not test this thoroughly but it would be
> > > > > > > > > great if someone could apply this to the current
> > head branch.
> > > > > > > > >
> > > > > > > > > Thanks
> > > > > > > > > --
> > > > > > > > > Torsten
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > > For additional commands, email: cocoon-dev-help@xml.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [patch] improved esql.xsl
Posted by John Morrison <jo...@ntlworld.com>.
Donald is busy at work with non-cocoon projects. I've been having a chat
with him offlist and he hopes to be back soon. (He didn't say when).
The main problem with esql (as far as I'm concerned) is that there are _FAR_
too many copies of it (C1 + all its branches, C2 + all its (two ;)
branches). Could we do something about shared tag libraries (sub cvs
repository ala Apache httpd2)?
J.
> -----Original Message-----
> From: ovidiu@cup.hp.com [mailto:ovidiu@cup.hp.com]
> Sent: Monday, 01 October 2001 5:41 pm
> To: Torsten Curdt; Carsten Ziegeler
> Cc: cocoon-dev@xml.apache.org
> Subject: Re: [patch] improved esql.xsl
>
>
> Torsten,
>
> I looked at your patch, and although I'm not very familiar with the
> esql logicsheet, your changes seem to be in the right direction. I
> would give a +1 to them (note I'm not a committer ;-).
>
> One improvement you can probably make is to pool the EsqlConnection
> objects, so you can obtain even better performance. This may be tricky
> to do though, as each connection might be connected using a different
> user account. These are only some thoughts, it doesn't mean you have
> to implement them now.
>
> Ovidiu
>
> PS: BTW, anybody knows what happened to Donald?
>
> On Mon, 01 Oct 2001 10:58:31 +0200, Torsten Curdt <tc...@dff.st> wrote:
>
> > could someone *PLEASE* have a look?
> > Thanks
> > --
> > Torsten
> >
> > > It has been pretty quite around Donald (Donald, are you still out
> > > there ;) Christian, maybe you could have a look?
> > >
> > > We have had no problem within any old esql page so far.
> > > But we can only test it with one database (sybase ASA).
> > >
> > > Thanks
> > > --
> > > Torsten
> > >
> > > > -----Original Message-----
> > > > From: Carsten Ziegeler [mailto:cziegeler@sundn.de]
> > > > Sent: Friday, September 28, 2001 8:12 AM
> > > > To: Cocoon-Dev@Xml. Apache. Org
> > > > Subject: AW: [patch] improved esql.xsl
> > > >
> > > >
> > > > Hi Team,
> > > >
> > > > could someone with more knowledge of eqsl than me
> > > > look at this patch, please?
> > > >
> > > > Carsten
> > > >
> > > > > -----Ursprungliche Nachricht-----
> > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > Gesendet: Donnerstag, 27. September 2001 11:39
> > > > > An: Carsten Ziegeler
> > > > > Cc: cocoon-dev@xml.apache.org
> > > > > Betreff: Re: AW: [patch] improved esql.xsl
> > > > >
> > > > >
> > > > > recreated it from the current CVS so it should be fine.
> > > > > Thanks
> > > > > --
> > > > > Torsten
> > > > >
> > > > > > Hi Torsten,
> > > > > >
> > > > > > it looks like your patch is still not applied.
> > > > > > Could you please test if it works and then
> > > > > > resend the patch, so we can apply it?
> > > > > >
> > > > > > Carsten
> > > > > >
> > > > > > > -----Ursprungliche Nachricht-----
> > > > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > > > Gesendet: Freitag, 21. September 2001 14:08
> > > > > > > An: cocoon-dev@xml.apache.org
> > > > > > > Betreff: RE: [patch] improved esql.xsl
> > > > > > >
> > > > > > >
> > > > > > > Are there any objections on this one?
> > > > > > > --
> > > > > > > Torsten
> > > > > > >
> > > > > > > > I straightened out the latest esql.xsl logicsheet
> > > > > > > >
> > > > > > > > - removed the inner classes (created real ones)
> > > > > > > > - moved redundant code into a helper class
> > > > > > > > - added support for jdbc ResultSet positioning
> > > > > > > > (now we can do paging not only for MySQL and PostgreSQL
> > > > > > > > and it's quite easy to add more)
> > > > > > > > - added a <esql:previous-results> as counterpart of
> > > > > > > <esql:more-results>
> > > > > > > >
> > > > > > > > Everything else should be same as before.
> > > > > > > >
> > > > > > > > I could not test this thoroughly but it would be
> > > > > > > > great if someone could apply this to the current
> head branch.
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > > --
> > > > > > > > Torsten
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org