[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11036: Fix zookeeper cas failed when create

[GitBox <gi...@apache.org>]

AlbumenJ commented on code in PR #11036:
URL: https://github.com/apache/dubbo/pull/11036#discussion_r1032789516


##########
dubbo-metadata/dubbo-metadata-report-zookeeper/src/main/java/org/apache/dubbo/metadata/store/zookeeper/ZookeeperMetadataReport.java:
##########
@@ -198,7 +198,7 @@ public boolean registerServiceAppMapping(String key, String group, String conten
                 throw new IllegalArgumentException("zookeeper publishConfigCas requires stat type ticket");
             }
             String pathKey = buildPathKey(group, key);
-            zkClient.createOrUpdate(pathKey, content, false, ticket == null ? 0 : ((Stat) ticket).getVersion());
+            zkClient.createOrUpdate(pathKey, content, false, ticket == null ? 0 : ((Stat) ticket).getVersion(), false);

Review Comment:
   If node is already exist when creating, will throw exception here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org