[jira] [Work logged] (HIVE-22746) Make TypeCheckProcFactory generic

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-22746?focusedWorklogId=376377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376377 ]

ASF GitHub Bot logged work on HIVE-22746:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jan/20 17:40
            Start Date: 23/Jan/20 17:40
    Worklog Time Spent: 10m 
      Work Description: jcamachor commented on pull request #887: HIVE-22746
URL: https://github.com/apache/hive/pull/887
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 376377)
    Remaining Estimate: 0h
            Time Spent: 10m

> Make TypeCheckProcFactory generic
> ---------------------------------
>
>                 Key: HIVE-22746
>                 URL: https://issues.apache.org/jira/browse/HIVE-22746
>             Project: Hive
>          Issue Type: Improvement
>          Components: CBO
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22746.01.patch, HIVE-22746.01.patch, HIVE-22746.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{TypeCheckProcFactory}} is responsible for processing AST nodes and generating ExprNode objects from them. When we generate the expressions for Calcite planning, we go through a {{AST node -> ExprNode -> RexNode}} transformation. We would like to avoid the overhead of going through the ExprNode, and thus generate directly the RexNode from the AST.
> To do that, the first step is to make {{TypeCheckProcFactory}} generic, so it can receive an expression factory and create expressions in different realms. For the time being, the only factory implementation is the ExprNode factory. Thus, this patch focuses mainly on refactoring {{TypeCheckProcFactory}} without breaking anything that is already working.
> In a follow-up patch, we will create a {{RexNode}} factory and use it when we parse the query in CalcitePlanner.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)