You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Alexander Menshikov (JIRA)" <ji...@apache.org> on 2018/04/04 12:59:00 UTC

[jira] [Commented] (IGNITE-6565) Use long type for size and keySize in cache metrics

    [ https://issues.apache.org/jira/browse/IGNITE-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425457#comment-16425457 ] 

Alexander Menshikov commented on IGNITE-6565:
---------------------------------------------

A lot of time has been passed after I created PR for the issue. The master dispersed with PR and start to use CacheMetricsImpl.EntriesStatMetrics class for storing size metrics. So I have to sync my PR with current master. Also, I  decided don't implement `long` to `int` safe cast, because it's not what this issue about.

After I resolve all conflict and fix to fail tests, I will update issue status and link to CI.

> Use long type for size and keySize in cache metrics
> ---------------------------------------------------
>
>                 Key: IGNITE-6565
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6565
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Ilya Kasnacheev
>            Assignee: Alexander Menshikov
>            Priority: Major
>              Labels: easyfix
>
> Currently it's int so for large caches there's no way to convey correct value.
> Should introduce getSizeLong() and getKeySizeLong()
> Also introduce the same in .Net and make sure that compatibility not broken when passing OP_LOCAL_METRICS and OP_GLOBAL_METRICS.
> BTW do we need keySize at all? What's it for?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)