You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/04 09:57:43 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h

pitrou commented on a change in pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#discussion_r625655299



##########
File path: cpp/src/parquet/types.h
##########
@@ -17,6 +17,16 @@
 
 #pragma once
 
+#ifdef _WIN32
+
+// parquet.thrift's OPTIONAL RepetitionType conflicts with a #define from
+// above, so we undefine it
+#ifdef OPTIONAL
+#undef OPTIONAL
+#endif

Review comment:
       Can you move this after the includes? Also, can you update the comment (there is no "define from above")?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org