[GitHub] [doris] morrySnow commented on a diff in pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #12421:
URL: https://github.com/apache/doris/pull/12421#discussion_r964499341


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAssertNumRows.java:
##########
@@ -59,7 +60,8 @@ public AssertNumRowsElement getAssertNumRowsElement() {
 
     @Override
     public String toString() {
-        return "LogicalAssertNumRows (" + assertNumRowsElement + ")";
+        return Utils.toSqlString("LogicalAssertNumRows (",

Review Comment:
   ```suggestion
           return Utils.toSqlString("LogicalAssertNumRows",
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/AssertNumRowsElement.java:
##########
@@ -75,7 +75,7 @@ public AssertNumRowsElement withChildren(List<Expression> children) {
     public String toString() {
         return Utils.toSqlString("desiredNumOfRows: ",
                 Long.toString(desiredNumOfRows),
-                "assertion: " + assertion);
+                "assertion: ", assertion);

Review Comment:
   the first parameter is plan name, and followed by k-v pairs.



##########
fe/fe-core/src/main/java/org/apache/doris/planner/CrossJoinNode.java:
##########
@@ -57,6 +58,26 @@ public CrossJoinNode(PlanNodeId id, PlanNode outer, PlanNode inner, TableRef inn
         nullableTupleIds.addAll(inner.getNullableTupleIds());
     }
 
+    /**
+     * .

Review Comment:
   comment: used by Nereids only



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org