You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Ben Smith (JIRA)" <ji...@apache.org> on 2008/11/06 11:05:45 UTC
[jira] Created: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Change in BodyType not reflected in JPA Samples - BodyTypeDb
------------------------------------------------------------
Key: SHINDIG-679
URL: https://issues.apache.org/jira/browse/SHINDIG-679
Project: Shindig
Issue Type: Bug
Components: Common Components (Java)
Environment: OSX
Reporter: Ben Smith
The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645451#action_12645451 ]
Ian Boston commented on SHINDIG-679:
------------------------------------
Patch is good, and applied,
Thanks (for correcting my mistakes... I made the change from String to float in the first place)
> Change in BodyType not reflected in JPA Samples - BodyTypeDb
> ------------------------------------------------------------
>
> Key: SHINDIG-679
> URL: https://issues.apache.org/jira/browse/SHINDIG-679
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java)
> Environment: OSX
> Reporter: Ben Smith
> Assignee: Ian Boston
> Attachments: fix-12407929-bug.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
> Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston closed SHINDIG-679.
------------------------------
Resolution: Fixed
All done
> Change in BodyType not reflected in JPA Samples - BodyTypeDb
> ------------------------------------------------------------
>
> Key: SHINDIG-679
> URL: https://issues.apache.org/jira/browse/SHINDIG-679
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java)
> Environment: OSX
> Reporter: Ben Smith
> Assignee: Ian Boston
> Attachments: fix-12407929-bug.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
> Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645652#action_12645652 ]
Ian Boston commented on SHINDIG-679:
------------------------------------
That makes sense.
> Change in BodyType not reflected in JPA Samples - BodyTypeDb
> ------------------------------------------------------------
>
> Key: SHINDIG-679
> URL: https://issues.apache.org/jira/browse/SHINDIG-679
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java)
> Environment: OSX
> Reporter: Ben Smith
> Assignee: Ian Boston
> Attachments: fix-12407929-bug.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
> Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SHINDIG-679) Change in BodyType not reflected in JPA Samples - BodyTypeDb
Posted by Ian Boston <ie...@tfd.co.uk>.
Good point,
I will fix ( in both places).
Ian
On 6 Nov 2008, at 13:37, Mathias Bogaert (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/SHINDIG-679?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=12645483#action_12645483 ]
>
> Mathias Bogaert commented on SHINDIG-679:
> -----------------------------------------
>
> Wouldn't is be better to use Float instead of the primitive type?
> Since now you can't detect a non-set weight or height (unless you
> check for 0, kinda ugly).
>
>> Change in BodyType not reflected in JPA Samples - BodyTypeDb
>> ------------------------------------------------------------
>>
>> Key: SHINDIG-679
>> URL: https://issues.apache.org/jira/browse/
>> SHINDIG-679
>> Project: Shindig
>> Issue Type: Bug
>> Components: Common Components (Java)
>> Environment: OSX
>> Reporter: Ben Smith
>> Assignee: Ian Boston
>> Attachments: fix-12407929-bug.patch
>>
>> Original Estimate: 0.25h
>> Remaining Estimate: 0.25h
>>
>> The change in org.apache.shindig.social.opensocial.model.BodyType,
>> turning the weight and height attributes to floats, was not
>> reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB
>> (in the samples project).
>> Requires changing the attribute and getter/setter methods to use
>> float, and the PopulatePerson test helper to send floats instead
>> of strings.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Posted by "Mathias Bogaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645483#action_12645483 ]
Mathias Bogaert commented on SHINDIG-679:
-----------------------------------------
Wouldn't is be better to use Float instead of the primitive type? Since now you can't detect a non-set weight or height (unless you check for 0, kinda ugly).
> Change in BodyType not reflected in JPA Samples - BodyTypeDb
> ------------------------------------------------------------
>
> Key: SHINDIG-679
> URL: https://issues.apache.org/jira/browse/SHINDIG-679
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java)
> Environment: OSX
> Reporter: Ben Smith
> Assignee: Ian Boston
> Attachments: fix-12407929-bug.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
> Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston reassigned SHINDIG-679:
----------------------------------
Assignee: Ian Boston
> Change in BodyType not reflected in JPA Samples - BodyTypeDb
> ------------------------------------------------------------
>
> Key: SHINDIG-679
> URL: https://issues.apache.org/jira/browse/SHINDIG-679
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java)
> Environment: OSX
> Reporter: Ben Smith
> Assignee: Ian Boston
> Attachments: fix-12407929-bug.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
> Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Posted by "Ben Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645454#action_12645454 ]
Ben Smith commented on SHINDIG-679:
-----------------------------------
Ace, cheers for the quick turn-around Ian.
http://www.bbc.co.uk/
This e-mail (and any attachments) is confidential and may contain personal views which are not the views of the BBC unless specifically stated.
If you have received it in error, please delete it from your system.
Do not use, copy or disclose the information in any way nor act in reliance on it and notify the sender immediately.
Please note that the BBC monitors e-mails sent or received.
Further communication will signify your consent to this.
> Change in BodyType not reflected in JPA Samples - BodyTypeDb
> ------------------------------------------------------------
>
> Key: SHINDIG-679
> URL: https://issues.apache.org/jira/browse/SHINDIG-679
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java)
> Environment: OSX
> Reporter: Ben Smith
> Assignee: Ian Boston
> Attachments: fix-12407929-bug.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
> Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-679) Change in BodyType not reflected in
JPA Samples - BodyTypeDb
Posted by "Ben Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Smith updated SHINDIG-679:
------------------------------
Attachment: fix-12407929-bug.patch
Simple patch to bring BodyTypeDb up to speed, and the test that creates one.
> Change in BodyType not reflected in JPA Samples - BodyTypeDb
> ------------------------------------------------------------
>
> Key: SHINDIG-679
> URL: https://issues.apache.org/jira/browse/SHINDIG-679
> Project: Shindig
> Issue Type: Bug
> Components: Common Components (Java)
> Environment: OSX
> Reporter: Ben Smith
> Attachments: fix-12407929-bug.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The change in org.apache.shindig.social.opensocial.model.BodyType, turning the weight and height attributes to floats, was not reflected in org.apache.shindig.social.opensocial.jpa.BodyTypeDB (in the samples project).
> Requires changing the attribute and getter/setter methods to use float, and the PopulatePerson test helper to send floats instead of strings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.