You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/05/03 11:25:22 UTC
[GitHub] [camel-k] orpiske opened a new pull request #2258: Support adjusting the log level for integrations
orpiske opened a new pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258
This solves issue #2000
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
Support adjusting the log level for integrations
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] heiko-braun commented on pull request #2258: Support adjusting the log level for integrations
Posted by GitBox <gi...@apache.org>.
heiko-braun commented on pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258#issuecomment-831203259
@orpiske Would it be possible to backport this onto 1.4.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2258: Support adjusting the log level for integrations
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258#issuecomment-831199543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2258: Support adjusting the log level for integrations
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258#issuecomment-831209370
> @orpiske I'm OK back porting the whole logging trait into 1.4.x branch.
Deal. I will take care of that and will open a PR for 1.4.x.
>
> Also, to wrap that great work with an equally great documentation, I would suggest to remove the existing page:
>
> https://camel.apache.org/camel-k/latest/configuration/logging.html
>
> And create a new one under "Observability/Logging" covering the new feature introduced by your work.
Thanks! Deal. I will do that on a separate PR, as I have to check a bit more carefully about removing the doc part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2258: Support adjusting the log level for integrations
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258#issuecomment-831208349
@orpiske I'm OK back porting the whole logging trait into 1.4.x branch.
Also, to wrap that great work with an equally great documentation, I would suggest to remove the existing page:
https://camel.apache.org/camel-k/latest/configuration/logging.html
And create a new one under "Observability/Logging" covering the new feature introduced by your work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2258: Support adjusting the log level for integrations
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258#issuecomment-831209809
@orpiske awesome! Once the documentation work is done, I think we can close #580.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske merged pull request #2258: Support adjusting the log level for integrations
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2258: Support adjusting the log level for integrations
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2258:
URL: https://github.com/apache/camel-k/pull/2258#issuecomment-831205853
> @orpiske Would it be possible to backport this onto 1.4.x?
I think so. We would need to backport other 2 patches/commits with the trait support, but it should be small.
That said: there is a work-around for 1.4 that would not require backporting. What do you think @astefanutti / @nicolaferraro ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org