You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "qinwei2004 (via GitHub)" <gi...@apache.org> on 2023/09/18 01:31:47 UTC

[GitHub] [nuttx] qinwei2004 opened a new pull request, #10655: arch/arm64: fix link RWX warning for NuttX arm64

qinwei2004 opened a new pull request, #10655:
URL: https://github.com/apache/nuttx/pull/10655

   ## Summary
     when using new gcc verion like:
     GNU ld (Arm GNU Toolchain 12.2.Rel1 (Build arm-12.24)) 2.39.0.20221210)
   
     we will get link warning like:
   
     aarch64-none-elf-ld: warning: XXX/nuttx has a LOAD segment with RWX permissions
   
     The patch fix the warning through add link option --no-warn-rwx-segments
   
   ## Impact
   None
   
   ## Testing
   Testing with compile
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #10655: arch/arm64: fix link RWX warning for NuttX arm64

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10655:
URL: https://github.com/apache/nuttx/pull/10655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/arm64: fix link RWX warning for NuttX arm64 [nuttx]

Posted by "qinwei2004 (via GitHub)" <gi...@apache.org>.
qinwei2004 commented on PR #10655:
URL: https://github.com/apache/nuttx/pull/10655#issuecomment-1754485090

   > Hi @qinwei2004: Sorry there's a minor issue with macOS Build, it shows some `sed` messages:
   > 
   > ```
   > $ tools/configure.sh pinephone:nsh
   > $ make
   > sed: illegal option -- r
   > ```
   > 
   > [(See the Complete Log)](https://gist.github.com/lupyuen/1c3f1f1d71993609bed3b31767595beb#file-pinephone-release-log-L282-L690)
   > 
   > The build completes successfully, so the `sed` message is harmless. I traced the message to this change: [arch/arm64/src/Toolchain.defs](https://github.com/apache/nuttx/blob/master/arch/arm64/src/Toolchain.defs#L169)
   > 
   > ```
   > # Workaround for GCC-12.2 linker warning
   > ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y)
   >   ifeq ($(GCCVER),)
   >     export GCCVER := $(shell $(CC) --version | grep gcc | sed -r "s/.* ([0-9]+\.[0-9]+).*/\1/" | cut -d'.' -f1)
   > ```
   > 
   > Which doesn't work as expected on macOS `sed`. Let me study the code above and see whether I can make it work on macOS and Linux `sed`. It might be similar to this fix: [e334786](https://github.com/apache/nuttx/commit/e334786f8124915e3ee2c56cca7ac08fbf0d9243). Thanks!
   > 
   > **Update:** I have submitted the PR: #10881
   
   @anchao , please check the issue and @lupyuen 's PR: #10881，thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/arm64: fix link RWX warning for NuttX arm64 [nuttx]

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #10655:
URL: https://github.com/apache/nuttx/pull/10655#issuecomment-1754697771

   The RWX warning is not specific for arm64. Maybe we can move the option adding to some upper level makefile? Or we should add it to all archs that use GCC?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/arm64: fix link RWX warning for NuttX arm64 [nuttx]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #10655:
URL: https://github.com/apache/nuttx/pull/10655#issuecomment-1754168154

   Hi @qinwei2004: Sorry there's a minor issue with macOS Build, it shows some `sed` messages:
   
   ```text
   $ tools/configure.sh pinephone:nsh
   $ make
   sed: illegal option -- r
   ```
   
   [(See the Complete Log)](https://gist.github.com/lupyuen/1c3f1f1d71993609bed3b31767595beb#file-pinephone-release-log-L282-L690)
   
   The build completes successfully, so the `sed` message is harmless. I traced the message to this change: [arch/arm64/src/Toolchain.defs](https://github.com/apache/nuttx/blob/master/arch/arm64/src/Toolchain.defs#L169)
   
   ```text
   # Workaround for GCC-12.2 linker warning
   ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y)
     ifeq ($(GCCVER),)
       export GCCVER := $(shell $(CC) --version | grep gcc | sed -r "s/.* ([0-9]+\.[0-9]+).*/\1/" | cut -d'.' -f1)
   ```
   
   Which doesn't work as expected on macOS `sed`. Let me study the code above and see whether I can make it work on macOS and Linux `sed`. It might be similar to this fix: https://github.com/apache/nuttx/commit/e334786f8124915e3ee2c56cca7ac08fbf0d9243. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org