You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/05/23 22:59:26 UTC

[PR] fix: route share-by-email link to correct dashboard path by type [texera]

mengw15 opened a new pull request, #5168:
URL: https://github.com/apache/texera/pull/5168

   ### What changes were proposed in this PR?
   
   `ShareAccessComponent.grantAccess` hard-coded the `dashboard/user/workflow/` path segment when constructing the share-notification email's "access the ... at ..." URL, regardless of which resource type the dialog was opened for. Because the dialog is opened with `type: "dataset"` / `type: "project"` / `type: "workflow"` from the respective list-item components, the link in the email for shared **datasets** and shared **projects** pointed at the workflow route and 404'd on click.
   
   Branch on `this.type` to pick the correct route from the existing `app-routing.constant.ts` constants:
   
   - `workflow` → `DASHBOARD_USER_WORKFLOW` (`/dashboard/user/workflow`)
   - `dataset` → `DASHBOARD_USER_DATASET` (`/dashboard/user/dataset`)
   - `project` → `DASHBOARD_USER_PROJECT` (`/dashboard/user/project`)
   
   `computing-unit` is unaffected — the existing `if (this.type !== "computing-unit")` guard already skips the URL line for that type.
   
   Note: the issue mentioned the dataset case only; the project case has the same defect and is fixed by the same change.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5163.
   
   Follow-up to #4200 (which fixed the missing `/dashboard/user/` prefix on the same line per #3583); this fixes the remaining hard-coded `workflow` segment.
   
   ### How was this PR tested?
   
   No automated test added: `share-access.component.ts` has no existing spec file, and creating one would require mocking ~8 injected dependencies (`ShareAccessService`, `UserService`, `GmailService`, `NzModalRef`, `NotificationService`, `DatasetService`, `WorkflowPersistService`, `WorkflowActionService`, `FormBuilder`) before the `grantAccess` method could be exercised — disproportionate to a five-line fix.
   
   Verified locally:
   
   - `yarn prettier --check src/app/dashboard/component/user/share-access/share-access.component.ts` — clean.
   - TypeScript compiles (the new identifiers `DASHBOARD_USER_DATASET` / `DASHBOARD_USER_PROJECT` / `DASHBOARD_USER_WORKFLOW` are existing exports from `app-routing.constant.ts:33-37`).
   
   Manual verification path:
   
   1. Share a dataset via the dataset list dashboard, entering a real email address.
   2. Check the recipient's inbox: the link should now read `https://<host>/dashboard/user/dataset/<did>` and resolve to the dataset detail page on click.
   3. Repeat for a project: link is `/dashboard/user/project/<pid>`.
   4. Repeat for a workflow: link is `/dashboard/user/workflow/<wid>` (unchanged behavior).
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: route share-by-email link to correct dashboard path by type [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #5168:
URL: https://github.com/apache/texera/pull/5168


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: route share-by-email link to correct dashboard path by type [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5168:
URL: https://github.com/apache/texera/pull/5168#issuecomment-4526761853

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5168?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `14.28571%` with `6 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 43.43%. Comparing base ([`d1cf4eb`](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35e67fc`](https://app.codecov.io/gh/apache/texera/commit/35e67fcbbe541bcfbfdd02a48425bd027975c179?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/5168?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ponent/user/share-access/share-access.component.ts](https://app.codecov.io/gh/apache/texera/pull/5168?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fdashboard%2Fcomponent%2Fuser%2Fshare-access%2Fshare-access.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9kYXNoYm9hcmQvY29tcG9uZW50L3VzZXIvc2hhcmUtYWNjZXNzL3NoYXJlLWFjY2Vzcy5jb21wb25lbnQudHM=) | 14.28% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/5168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #5168      +/-   ##
   ============================================
   - Coverage     43.43%   43.43%   -0.01%     
     Complexity     2216     2216              
   ============================================
     Files          1049     1049              
     Lines         40575    40580       +5     
     Branches       4321     4324       +3     
   ============================================
   + Hits          17625    17626       +1     
   - Misses        21855    21859       +4     
     Partials       1095     1095              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.92% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.38% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `19.35% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.61% <14.28%> (-0.01%)` | :arrow_down: | |
   | [python](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.50% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.39% <ø> (ø)` | | Carriedforward from [d1cf4eb](https://app.codecov.io/gh/apache/texera/commit/d1cf4ebde7f49346533e3c9506013f97c7fef88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5168?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org