You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "abstractdog (via GitHub)" <gi...@apache.org> on 2026/09/18 11:13:55 UTC
[PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
abstractdog opened a new pull request, #539:
URL: https://github.com/apache/tez/pull/539
Route each key/value pair through Hadoop's ConfigRedactor when building the ATS configuration map, so values matching the cluster's configured sensitive-key pattern are masked in the map published to Timeline. Adds a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #539:
URL: https://github.com/apache/tez/pull/539#issuecomment-5730462218
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 11m 49s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 45s | | master passed |
| +1 :green_heart: | compile | 4m 2s | | master passed |
| +1 :green_heart: | checkstyle | 0m 43s | | master passed |
| +1 :green_heart: | javadoc | 0m 31s | | master passed |
| +0 :ok: | spotbugs | 1m 44s | | tez-dag in master has 537 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 44s | | the patch passed |
| +1 :green_heart: | codespell | 1m 35s | | No new issues. |
| +1 :green_heart: | compile | 4m 3s | | the patch passed |
| +1 :green_heart: | javac | 4m 3s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 37s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 28s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 54s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 77m 34s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not generate ASF License warnings. |
| | | 115m 43s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/1/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux 9ad9e79cb528 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7 15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / 0e9f756609fe06835cb8f50e0f8e90a3e8282a6f |
| Default Java | Eclipse Adoptium-21.0.12+8-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/1/testReport/ |
| Max. process+thread count | 1343 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #539:
URL: https://github.com/apache/tez/pull/539#discussion_r4046803964
##########
tez-dag/src/test/java/org/apache/tez/dag/history/utils/TestDAGUtils.java:
##########
@@ -222,4 +222,32 @@ public void testConvertDAGPlanToATSMap() throws IOException, JSONException {
}
}
+ @Test
+ public void testConvertConfigurationToATSMapRedactsSecrets() {
+ Configuration conf = new Configuration(false);
Review Comment:
Using `new Configuration(false)` here means the test is not loading Hadoop default resources (including defaults for `hadoop.security.sensitive-config-keys`), so the redaction expectations can become dependent on `ConfigRedactor` implementation details rather than the configured defaults. Consider loading defaults (or explicitly setting the sensitive-key pattern) so the test exercises the same behavior as production AM configs.
##########
tez-dag/src/test/java/org/apache/tez/dag/history/utils/TestDAGUtils.java:
##########
@@ -222,4 +222,32 @@ public void testConvertDAGPlanToATSMap() throws IOException, JSONException {
}
}
+ @Test
+ public void testConvertConfigurationToATSMapRedactsSecrets() {
+ Configuration conf = new Configuration(false);
+ // Non-sensitive properties must pass through unchanged.
+ conf.set("tez.am.dag.scheduler.class",
+ "org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrder");
+ conf.set("mapreduce.job.name", "normal-job");
+ // These keys are covered by Hadoop's default
+ // hadoop.security.sensitive-config-keys pattern.
+ conf.set("fs.s3a.secret.key", "wJalrXUtnFEMI/K7MDENG/bPxRfiCYSECRET");
+ conf.set("fs.s3a.access.key", "AKIAIOSFODNN7EXAMPLE");
+ conf.set("ssl.server.keystore.password", "SuperSecretKeystorePass!");
+ conf.set("hadoop.security.credential.provider.password", "credpass");
+
+ Map<String, String> ats = DAGUtils.convertConfigurationToATSMap(conf);
+
+ assertEquals("org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrder",
+ ats.get("tez.am.dag.scheduler.class"));
+ assertEquals("normal-job", ats.get("mapreduce.job.name"));
+ assertFalse(ats.get("fs.s3a.secret.key").contains("SECRET"),
+ "s3a secret key must be redacted, got: " + ats.get("fs.s3a.secret.key"));
+ assertFalse(ats.get("ssl.server.keystore.password").contains("SuperSecret"),
+ "keystore password must be redacted, got: " + ats.get("ssl.server.keystore.password"));
+ assertFalse(ats.get("hadoop.security.credential.provider.password").contains("credpass"),
+ "credential provider password must be redacted, got: "
+ + ats.get("hadoop.security.credential.provider.password"));
Review Comment:
The test values for S3A credentials currently resemble real AWS key formats (e.g., `AKIA...` and the well-known AWS secret-key example), which can trigger secret-scanning/false-positive credential alerts and may violate repository hygiene. Use clearly fake placeholders that still include the substrings you assert against, and also assert that `fs.s3a.access.key` is redacted since it is included in the test setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #539:
URL: https://github.com/apache/tez/pull/539#discussion_r4061890699
##########
tez-dag/src/test/java/org/apache/tez/dag/history/utils/TestDAGUtils.java:
##########
@@ -222,4 +222,32 @@ public void testConvertDAGPlanToATSMap() throws IOException, JSONException {
}
}
+ @Test
+ public void testConvertConfigurationToATSMapRedactsSecrets() {
+ Configuration conf = new Configuration(false);
+ // Non-sensitive properties must pass through unchanged.
+ conf.set("tez.am.dag.scheduler.class",
+ "org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrder");
+ conf.set("mapreduce.job.name", "normal-job");
+ // These keys are covered by Hadoop's default
+ // hadoop.security.sensitive-config-keys pattern.
+ conf.set("fs.s3a.secret.key", "wJalrXUtnFEMI/K7MDENG/bPxRfiCYSECRET");
+ conf.set("fs.s3a.access.key", "AKIAIOSFODNN7EXAMPLE");
+ conf.set("ssl.server.keystore.password", "SuperSecretKeystorePass!");
+ conf.set("hadoop.security.credential.provider.password", "credpass");
+
+ Map<String, String> ats = DAGUtils.convertConfigurationToATSMap(conf);
+
+ assertEquals("org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrder",
+ ats.get("tez.am.dag.scheduler.class"));
+ assertEquals("normal-job", ats.get("mapreduce.job.name"));
+ assertFalse(ats.get("fs.s3a.secret.key").contains("SECRET"),
+ "s3a secret key must be redacted, got: " + ats.get("fs.s3a.secret.key"));
+ assertFalse(ats.get("ssl.server.keystore.password").contains("SuperSecret"),
+ "keystore password must be redacted, got: " + ats.get("ssl.server.keystore.password"));
+ assertFalse(ats.get("hadoop.security.credential.provider.password").contains("credpass"),
+ "credential provider password must be redacted, got: "
+ + ats.get("hadoop.security.credential.provider.password"));
Review Comment:
ack, even if I like these realistic values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #539:
URL: https://github.com/apache/tez/pull/539#issuecomment-5761674857
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 58s | | master passed |
| +1 :green_heart: | compile | 4m 2s | | master passed |
| +1 :green_heart: | checkstyle | 0m 43s | | master passed |
| +1 :green_heart: | javadoc | 0m 31s | | master passed |
| +0 :ok: | spotbugs | 1m 40s | | tez-dag in master has 537 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 50s | | the patch passed |
| +1 :green_heart: | codespell | 1m 34s | | No new issues. |
| +1 :green_heart: | compile | 4m 2s | | the patch passed |
| +1 :green_heart: | javac | 4m 2s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 38s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 30s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 52s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 75m 38s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/2/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not generate ASF License warnings. |
| | | 102m 55s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.history.TestHistoryParser |
| | tez.dag.app.TestSpeculation |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/2/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux 564e25b4f947 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7 15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / 0e9f756609fe06835cb8f50e0f8e90a3e8282a6f |
| Default Java | Eclipse Adoptium-21.0.12+8-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/2/testReport/ |
| Max. process+thread count | 1544 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/2/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #539:
URL: https://github.com/apache/tez/pull/539#discussion_r4061881231
##########
tez-dag/src/test/java/org/apache/tez/dag/history/utils/TestDAGUtils.java:
##########
@@ -222,4 +222,32 @@ public void testConvertDAGPlanToATSMap() throws IOException, JSONException {
}
}
+ @Test
+ public void testConvertConfigurationToATSMapRedactsSecrets() {
+ Configuration conf = new Configuration(false);
Review Comment:
ack, DAGAppMaster for example simply instantiates `new Configuration()`, so this makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #539:
URL: https://github.com/apache/tez/pull/539#issuecomment-6471520428
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 19s | | master passed |
| +1 :green_heart: | compile | 4m 0s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | javadoc | 0m 29s | | master passed |
| +0 :ok: | spotbugs | 1m 46s | | tez-dag in master has 537 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 0s | | the patch passed |
| +1 :green_heart: | codespell | 1m 50s | | No new issues. |
| +1 :green_heart: | compile | 4m 0s | | the patch passed |
| +1 :green_heart: | javac | 4m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 36s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 57s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 74m 42s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 32s | | The patch does not generate ASF License warnings. |
| | | 102m 44s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/5/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux e878f191d212 5.15.0-186-generic #196-Ubuntu SMP Sat Jun 20 16:09:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / b434f5ccdf4fd7384e4dfea8df9947bf31193416 |
| Default Java | Eclipse Adoptium-21.0.12.1+1-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/5/testReport/ |
| Max. process+thread count | 1442 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/5/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #539:
URL: https://github.com/apache/tez/pull/539#issuecomment-6442617514
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 10m 45s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 10s | | master passed |
| +1 :green_heart: | compile | 3m 59s | | master passed |
| +1 :green_heart: | checkstyle | 0m 41s | | master passed |
| +1 :green_heart: | javadoc | 0m 29s | | master passed |
| +0 :ok: | spotbugs | 1m 45s | | tez-dag in master has 537 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 2s | | the patch passed |
| +1 :green_heart: | codespell | 1m 50s | | No new issues. |
| +1 :green_heart: | compile | 4m 0s | | the patch passed |
| +1 :green_heart: | javac | 4m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 37s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 57s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 74m 19s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/3/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 31s | | The patch does not generate ASF License warnings. |
| | | 112m 24s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.dag.app.rm.TestTaskSchedulerManager |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/3/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux f0238f8a4562 5.15.0-186-generic #196-Ubuntu SMP Sat Jun 20 16:09:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / 5496f7322b0e1c56779f4bdf81090210e58a986c |
| Default Java | Eclipse Adoptium-21.0.12.1+1-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/3/testReport/ |
| Max. process+thread count | 1455 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/3/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #539:
URL: https://github.com/apache/tez/pull/539#discussion_r4410391350
##########
tez-dag/src/test/java/org/apache/tez/dag/history/utils/TestDAGUtils.java:
##########
@@ -222,4 +223,48 @@ public void testConvertDAGPlanToATSMap() throws IOException, JSONException {
}
}
+ @Test
+ public void testConvertConfigurationToATSMapRedactsSecrets() {
+ // Defaults must load: ConfigRedactor's fallback pattern is narrower than
+ // core-default.xml and misses fs.s3a.session.token.
+ Configuration conf = new Configuration();
+ conf.set("tez.am.dag.scheduler.class",
+ "org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrder");
Review Comment:
can we rather than hardcoding, using the Class.getName() and for the configs as well, the Config variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #539:
URL: https://github.com/apache/tez/pull/539#issuecomment-6468471067
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 33s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 3s | | master passed |
| +1 :green_heart: | compile | 3m 58s | | master passed |
| +1 :green_heart: | checkstyle | 0m 40s | | master passed |
| +1 :green_heart: | javadoc | 0m 29s | | master passed |
| +0 :ok: | spotbugs | 1m 45s | | tez-dag in master has 537 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 4s | | the patch passed |
| +1 :green_heart: | codespell | 1m 49s | | No new issues. |
| +1 :green_heart: | compile | 3m 59s | | the patch passed |
| +1 :green_heart: | javac | 3m 59s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 37s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 56s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 76m 16s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/4/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 32s | | The patch does not generate ASF License warnings. |
| | | 103m 56s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.analyzer.TestAnalyzer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/4/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux e46161590352 5.15.0-186-generic #196-Ubuntu SMP Sat Jun 20 16:09:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / b434f5ccdf4fd7384e4dfea8df9947bf31193416 |
| Default Java | Eclipse Adoptium-21.0.12.1+1-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/4/testReport/ |
| Max. process+thread count | 1450 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/4/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "tez-yetus (via GitHub) via issues" <is...@tez.apache.org>.
tez-yetus commented on PR #539:
URL: https://github.com/apache/tez/pull/539#issuecomment-6579544320
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 9m 6s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 4s | | master passed |
| +1 :green_heart: | compile | 3m 59s | | master passed |
| +1 :green_heart: | checkstyle | 0m 42s | | master passed |
| +1 :green_heart: | javadoc | 0m 29s | | master passed |
| +0 :ok: | spotbugs | 1m 45s | | tez-dag in master has 537 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 3s | | the patch passed |
| +1 :green_heart: | codespell | 1m 51s | | No new issues. |
| +1 :green_heart: | compile | 4m 0s | | the patch passed |
| +1 :green_heart: | javac | 4m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 37s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 57s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 72m 39s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 32s | | The patch does not generate ASF License warnings. |
| | | 109m 4s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/6/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux 13a31662a9e0 5.15.0-186-generic #196-Ubuntu SMP Sat Jun 20 16:09:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / b434f5ccdf4fd7384e4dfea8df9947bf31193416 |
| Default Java | Eclipse Adoptium-21.0.13+9-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/6/testReport/ |
| Max. process+thread count | 1401 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-539/6/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4756: DAGUtils: configuration handling improvements [tez]
Posted by "abstractdog (via GitHub) via issues" <is...@tez.apache.org>.
abstractdog commented on PR #539:
URL: https://github.com/apache/tez/pull/539#issuecomment-6577271867
thanks for the review @ayushtkn , addressed your comment in https://github.com/apache/tez/pull/539/changes/b285e5f730b1ef6fd918fd3fa3ce3cdae30296dc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org