You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/02 11:42:38 UTC
[GitHub] [dubbo] 24kpure opened a new pull request #9883: typo & format extension
24kpure opened a new pull request #9883:
URL: https://github.com/apache/dubbo/pull/9883
## What is the purpose of the change
I've been studying extension recently and found that some codes can be optimized.
## Brief changelog
- remove unless code
- add some method annotion like `SuppressWarnings`
- replace some `for` useage with stream
- reduce `if` nesting usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9883: typo & format extension
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9883:
URL: https://github.com/apache/dubbo/pull/9883#issuecomment-1086626712
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9883](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (420b1d9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0bac2faae2d5eafbe2f42a76ce06f510aff5392a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bac2fa) will **decrease** coverage by `0.31%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9883 +/- ##
============================================
- Coverage 65.69% 65.37% -0.32%
- Complexity 296 319 +23
============================================
Files 1213 1213
Lines 52905 52860 -45
Branches 8011 7980 -31
============================================
- Hits 34754 34557 -197
- Misses 14359 14486 +127
- Partials 3792 3817 +25
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/common/extension/ExtensionDirector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkRpcmVjdG9yLmphdmE=) | `96.66% <ø> (ø)` | |
| [...nsion/support/MultiInstanceActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvTXVsdGlJbnN0YW5jZUFjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `5.26% <0.00%> (ø)` | |
| [...bo/common/extension/support/WrapperComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvV3JhcHBlckNvbXBhcmF0b3IuamF2YQ==) | `57.14% <ø> (ø)` | |
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvQWN0aXZhdGVDb21wYXJhdG9yLmphdmE=) | `76.92% <66.66%> (ø)` | |
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `80.24% <69.23%> (+0.84%)` | :arrow_up: |
| [...o/common/extension/AdaptiveClassCodeGenerator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0FkYXB0aXZlQ2xhc3NDb2RlR2VuZXJhdG9yLmphdmE=) | `92.53% <100.00%> (ø)` | |
| [...on/extension/inject/AdaptiveExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9BZGFwdGl2ZUV4dGVuc2lvbkluamVjdG9yLmphdmE=) | `88.23% <100.00%> (-1.77%)` | :arrow_down: |
| [.../rpc/protocol/tri/transport/TripleTailHandler.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L1RyaXBsZVRhaWxIYW5kbGVyLmphdmE=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...o/rpc/protocol/tri/transport/GracefulShutdown.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L0dyYWNlZnVsU2h1dGRvd24uamF2YQ==) | `50.00% <0.00%> (-35.72%)` | :arrow_down: |
| [...dubbo/remoting/zookeeper/ZookeeperTransporter.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvWm9va2VlcGVyVHJhbnNwb3J0ZXIuamF2YQ==) | `55.55% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [61 more](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bac2fa...420b1d9](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9883: typo & format extension
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/dubbo/pull/9883#issuecomment-1086626712
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9883](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (420b1d9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0bac2faae2d5eafbe2f42a76ce06f510aff5392a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bac2fa) will **decrease** coverage by `0.17%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9883 +/- ##
============================================
- Coverage 65.69% 65.51% -0.18%
- Complexity 296 319 +23
============================================
Files 1213 1213
Lines 52905 52896 -9
Branches 8011 8008 -3
============================================
- Hits 34754 34657 -97
- Misses 14359 14427 +68
- Partials 3792 3812 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/common/extension/ExtensionDirector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkRpcmVjdG9yLmphdmE=) | `96.66% <ø> (ø)` | |
| [...nsion/support/MultiInstanceActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvTXVsdGlJbnN0YW5jZUFjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `5.26% <0.00%> (ø)` | |
| [...bo/common/extension/support/WrapperComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvV3JhcHBlckNvbXBhcmF0b3IuamF2YQ==) | `57.14% <ø> (ø)` | |
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvQWN0aXZhdGVDb21wYXJhdG9yLmphdmE=) | `76.92% <66.66%> (ø)` | |
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `80.24% <69.23%> (+0.84%)` | :arrow_up: |
| [...o/common/extension/AdaptiveClassCodeGenerator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0FkYXB0aXZlQ2xhc3NDb2RlR2VuZXJhdG9yLmphdmE=) | `92.53% <100.00%> (ø)` | |
| [...on/extension/inject/AdaptiveExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9BZGFwdGl2ZUV4dGVuc2lvbkluamVjdG9yLmphdmE=) | `88.23% <100.00%> (-1.77%)` | :arrow_down: |
| [.../rpc/protocol/tri/transport/TripleTailHandler.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L1RyaXBsZVRhaWxIYW5kbGVyLmphdmE=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...o/rpc/protocol/tri/transport/GracefulShutdown.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L0dyYWNlZnVsU2h1dGRvd24uamF2YQ==) | `50.00% <0.00%> (-35.72%)` | :arrow_down: |
| [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bac2fa...420b1d9](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9883: typo & format extension
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/dubbo/pull/9883#issuecomment-1086626712
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9883](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (420b1d9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0bac2faae2d5eafbe2f42a76ce06f510aff5392a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bac2fa) will **decrease** coverage by `0.05%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9883 +/- ##
============================================
- Coverage 65.69% 65.63% -0.06%
- Complexity 296 319 +23
============================================
Files 1213 1213
Lines 52905 52896 -9
Branches 8011 8008 -3
============================================
- Hits 34754 34719 -35
- Misses 14359 14377 +18
- Partials 3792 3800 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/common/extension/ExtensionDirector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkRpcmVjdG9yLmphdmE=) | `96.66% <ø> (ø)` | |
| [...nsion/support/MultiInstanceActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvTXVsdGlJbnN0YW5jZUFjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `5.26% <0.00%> (ø)` | |
| [...bo/common/extension/support/WrapperComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvV3JhcHBlckNvbXBhcmF0b3IuamF2YQ==) | `57.14% <ø> (ø)` | |
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvQWN0aXZhdGVDb21wYXJhdG9yLmphdmE=) | `76.92% <66.66%> (ø)` | |
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `80.24% <69.23%> (+0.84%)` | :arrow_up: |
| [...o/common/extension/AdaptiveClassCodeGenerator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0FkYXB0aXZlQ2xhc3NDb2RlR2VuZXJhdG9yLmphdmE=) | `92.53% <100.00%> (ø)` | |
| [...on/extension/inject/AdaptiveExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9BZGFwdGl2ZUV4dGVuc2lvbkluamVjdG9yLmphdmE=) | `88.23% <100.00%> (-1.77%)` | :arrow_down: |
| [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
| [...g/apache/dubbo/remoting/api/ConnectionHandler.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvQ29ubmVjdGlvbkhhbmRsZXIuamF2YQ==) | `45.45% <0.00%> (-9.10%)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `87.17% <0.00%> (-5.13%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bac2fa...420b1d9](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9883: typo & format extension
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/dubbo/pull/9883#issuecomment-1086626712
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9883](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (420b1d9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0bac2faae2d5eafbe2f42a76ce06f510aff5392a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bac2fa) will **decrease** coverage by `0.00%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9883 +/- ##
============================================
- Coverage 65.69% 65.68% -0.01%
- Complexity 296 319 +23
============================================
Files 1213 1213
Lines 52905 52896 -9
Branches 8011 8008 -3
============================================
- Hits 34754 34745 -9
- Misses 14359 14360 +1
+ Partials 3792 3791 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/common/extension/ExtensionDirector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkRpcmVjdG9yLmphdmE=) | `96.66% <ø> (ø)` | |
| [...nsion/support/MultiInstanceActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvTXVsdGlJbnN0YW5jZUFjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `5.26% <0.00%> (ø)` | |
| [...bo/common/extension/support/WrapperComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvV3JhcHBlckNvbXBhcmF0b3IuamF2YQ==) | `57.14% <ø> (ø)` | |
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvQWN0aXZhdGVDb21wYXJhdG9yLmphdmE=) | `76.92% <66.66%> (ø)` | |
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `80.24% <69.23%> (+0.84%)` | :arrow_up: |
| [...o/common/extension/AdaptiveClassCodeGenerator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0FkYXB0aXZlQ2xhc3NDb2RlR2VuZXJhdG9yLmphdmE=) | `92.53% <100.00%> (ø)` | |
| [...on/extension/inject/AdaptiveExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9BZGFwdGl2ZUV4dGVuc2lvbkluamVjdG9yLmphdmE=) | `88.23% <100.00%> (-1.77%)` | :arrow_down: |
| [...g/apache/dubbo/remoting/api/ConnectionHandler.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvQ29ubmVjdGlvbkhhbmRsZXIuamF2YQ==) | `45.45% <0.00%> (-9.10%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L1dyaXRlUXVldWUuamF2YQ==) | `73.80% <0.00%> (-4.77%)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `88.03% <0.00%> (-4.28%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bac2fa...420b1d9](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9883: typo & format extension
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/dubbo/pull/9883#issuecomment-1086626712
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9883](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (420b1d9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0bac2faae2d5eafbe2f42a76ce06f510aff5392a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bac2fa) will **decrease** coverage by `0.14%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9883 +/- ##
============================================
- Coverage 65.69% 65.55% -0.15%
- Complexity 296 319 +23
============================================
Files 1213 1213
Lines 52905 52896 -9
Branches 8011 8008 -3
============================================
- Hits 34754 34674 -80
- Misses 14359 14412 +53
- Partials 3792 3810 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/common/extension/ExtensionDirector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkRpcmVjdG9yLmphdmE=) | `96.66% <ø> (ø)` | |
| [...nsion/support/MultiInstanceActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvTXVsdGlJbnN0YW5jZUFjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `5.26% <0.00%> (ø)` | |
| [...bo/common/extension/support/WrapperComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvV3JhcHBlckNvbXBhcmF0b3IuamF2YQ==) | `57.14% <ø> (ø)` | |
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvQWN0aXZhdGVDb21wYXJhdG9yLmphdmE=) | `76.92% <66.66%> (ø)` | |
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `80.24% <69.23%> (+0.84%)` | :arrow_up: |
| [...o/common/extension/AdaptiveClassCodeGenerator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0FkYXB0aXZlQ2xhc3NDb2RlR2VuZXJhdG9yLmphdmE=) | `92.53% <100.00%> (ø)` | |
| [...on/extension/inject/AdaptiveExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9BZGFwdGl2ZUV4dGVuc2lvbkluamVjdG9yLmphdmE=) | `88.23% <100.00%> (-1.77%)` | :arrow_down: |
| [.../rpc/protocol/tri/transport/TripleTailHandler.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L1RyaXBsZVRhaWxIYW5kbGVyLmphdmE=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...o/rpc/protocol/tri/transport/GracefulShutdown.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L0dyYWNlZnVsU2h1dGRvd24uamF2YQ==) | `50.00% <0.00%> (-35.72%)` | :arrow_down: |
| [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bac2fa...420b1d9](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9883: typo & format extension
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/dubbo/pull/9883#issuecomment-1086626712
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9883](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (420b1d9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0bac2faae2d5eafbe2f42a76ce06f510aff5392a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bac2fa) will **decrease** coverage by `0.04%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9883 +/- ##
============================================
- Coverage 65.69% 65.64% -0.05%
- Complexity 296 319 +23
============================================
Files 1213 1213
Lines 52905 52896 -9
Branches 8011 8008 -3
============================================
- Hits 34754 34726 -28
- Misses 14359 14373 +14
- Partials 3792 3797 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/common/extension/ExtensionDirector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkRpcmVjdG9yLmphdmE=) | `96.66% <ø> (ø)` | |
| [...nsion/support/MultiInstanceActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvTXVsdGlJbnN0YW5jZUFjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `5.26% <0.00%> (ø)` | |
| [...bo/common/extension/support/WrapperComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvV3JhcHBlckNvbXBhcmF0b3IuamF2YQ==) | `57.14% <ø> (ø)` | |
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvQWN0aXZhdGVDb21wYXJhdG9yLmphdmE=) | `76.92% <66.66%> (ø)` | |
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `80.24% <69.23%> (+0.84%)` | :arrow_up: |
| [...o/common/extension/AdaptiveClassCodeGenerator.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0FkYXB0aXZlQ2xhc3NDb2RlR2VuZXJhdG9yLmphdmE=) | `92.53% <100.00%> (ø)` | |
| [...on/extension/inject/AdaptiveExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9BZGFwdGl2ZUV4dGVuc2lvbkluamVjdG9yLmphdmE=) | `88.23% <100.00%> (-1.77%)` | :arrow_down: |
| [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
| [...g/apache/dubbo/remoting/api/ConnectionHandler.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvQ29ubmVjdGlvbkhhbmRsZXIuamF2YQ==) | `45.45% <0.00%> (-9.10%)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `87.17% <0.00%> (-5.13%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo/pull/9883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bac2fa...420b1d9](https://codecov.io/gh/apache/dubbo/pull/9883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org