[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1835: [CELEBORN-908][WORKER]Tweak pause and resume logic && add unit test MemoryManager memory check thread

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1835:
URL: https://github.com/apache/incubator-celeborn/pull/1835#discussion_r1305450577


##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/MemoryManager.java:
##########
@@ -274,6 +240,59 @@ public ServingState currentServingState() {
     return isPaused ? ServingState.PUSH_PAUSED : ServingState.NONE_PAUSED;
   }
 
+  @VisibleForTesting
+  protected void switchServingState() {
+    ServingState lastState = servingState;
+    servingState = currentServingState();
+    if (lastState == servingState) {
+      if (servingState != ServingState.NONE_PAUSED) {
+        logger.debug("Trigger action: TRIM");

Review Comment:
   why debug here and info other places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org