You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/04 14:19:05 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request, #9954: [Enhancement](Join) Construct output tuple in join node
EmmyMiao87 opened a new pull request, #9954:
URL: https://github.com/apache/incubator-doris/pull/9954
# Proposed changes
Closed #7901
## Problem Summary
In a vectorized scenario, the query plan will generate a new tuple for the join node.
This tuple mainly describes the output schema of the join node.
Adding this tuple mainly solves the problem that the input schema of the join node is different from the output schema.
For example:
1. The case where the null side column caused by outer join is converted to nullable.
2. The projection of the outer tuple.
* Since this function is unavailable for non-vectorized code,
the new attributes vOutputTupleDesc and vSrcToOutputSMap accompanying this function are unique to vectorization.*
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9954: [Enhancement](Join) Construct output tuple in join node
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9954:
URL: https://github.com/apache/incubator-doris/pull/9954#issuecomment-1146633628
Could you add some ut for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 closed pull request #9954: [Fix](Join) Fix the bug of outer join function under vectorization
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 closed pull request #9954: [Fix](Join) Fix the bug of outer join function under vectorization
URL: https://github.com/apache/doris/pull/9954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #9954: [Fix](Join) Solve the problem of incorrectly evaluating column null properties when combining inline view and outer join.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9954:
URL: https://github.com/apache/doris/pull/9954#issuecomment-1165468587
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 commented on pull request #9954: [Fix](Join) Fix the bug of outer join function under vectorization
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on PR #9954:
URL: https://github.com/apache/doris/pull/9954#issuecomment-1166811691
The contents of this pr are merged into the new pr#10437 and submitted together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #9954: [Fix](Join) Solve the problem of incorrectly evaluating column null properties when combining inline view and outer join.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9954:
URL: https://github.com/apache/doris/pull/9954#issuecomment-1165468557
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #9954: [Enhancement](Join) Construct output tuple in join node
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9954:
URL: https://github.com/apache/doris/pull/9954#issuecomment-1163149736
Fixed in #10323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman closed pull request #9954: [Enhancement](Join) Construct output tuple in join node
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #9954: [Enhancement](Join) Construct output tuple in join node
URL: https://github.com/apache/doris/pull/9954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9954: [Enhancement](Join) Construct output tuple in join node
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9954:
URL: https://github.com/apache/incubator-doris/pull/9954#discussion_r895315175
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -410,6 +410,10 @@ struct THashJoinNode {
// hash output column
6: optional list<Types.TSlotId> hash_output_slot_ids
+
+ 7: optional list<Exprs.TExpr> srcExprList
Review Comment:
use `src_expr_list`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #9954: [Enhancement](Join) Construct output tuple in join node
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #9954:
URL: https://github.com/apache/doris/pull/9954#discussion_r901537140
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -893,7 +893,6 @@ private void filterDeletedRows(Analyzer analyzer) throws AnalysisException {
SlotRef deleteSignSlot = new SlotRef(desc.getAliasAsName(), Column.DELETE_SIGN);
deleteSignSlot.analyze(analyzer);
deleteSignSlot.getDesc().setIsMaterialized(true);
- deleteSignSlot.getDesc().setIsNullable(analyzer.isOuterMaterializedJoined(desc.getId()));
Review Comment:
we also need to remove `setIsNullable` in [Analyzer#registerColumnRef ](https://github.com/apache/doris/blob/b7b78ae7079a61eadab0e78d9e9c9792dd0af1b3/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java#L796)
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -409,6 +409,10 @@ struct THashJoinNode {
// hash output column
6: optional list<Types.TSlotId> hash_output_slot_ids
+
+ 7: optional list<Exprs.TExpr> srcExprList
+
+ 8: optional Types.TTupleId voutput_tuple_id
Review Comment:
move it to TPlanNode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org