You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/05/29 15:05:15 UTC
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #44: stream: fix regression in JsonFraming
He-Pin commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1209393862
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/JsonFramingSpec.scala:
##########
@@ -41,7 +41,7 @@ class JsonFramingSpec extends PekkoSpec {
|""".stripMargin // also should complete once notices end of array
val result =
- Source.single(ByteString(input)).via(JsonFraming.objectScanner(Int.MaxValue)).runFold(Seq.empty[String]) {
+ Source.single(ByteString(input)).via(JsonFraming.objectScanner(64)).runFold(Seq.empty[String]) {
Review Comment:
I changed it `54`, the test case not pass.
```
JSON element exceeded maximumObjectLength (54 bytes)!
org.apache.pekko.stream.scaladsl.Framing$FramingException: JSON element exceeded maximumObjectLength (54 bytes)!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org