[GitHub] [mina-sshd] fcav1973 commented on a change in pull request #80: SSHD-849 working code for pull request

[GitBox <gi...@apache.org>]

fcav1973 commented on a change in pull request #80: SSHD-849 working code for pull request
URL: https://github.com/apache/mina-sshd/pull/80#discussion_r360817171
 
 

 ##########
 File path: sshd-core/src/main/java/org/apache/sshd/common/forward/DefaultForwardingFilter.java
 ##########
 @@ -1082,7 +1093,7 @@ public void messageReceived(IoSession session, Readable message) throws Exceptio
                       session, channel, totalMessages, message.available());
             }
 
-            OpenFuture future = channel.getOpenFuture();
+            OpenFuture future = channel.getPendingMessagesQueue().getCompletedFuture();
 
 Review comment:
   
   ```suggestion
               ClientChannelPendingMessagesQueue messagesQueue = channel.getPendingMessagesQueue();
               
               OpenFuture future = messagesQueue.getCompletedFuture();
               
               Consumer<Throwable> errHandler = future.isOpened() ? null : e -> {
                   try {
                       exceptionCaught(session, e);
                   } catch (Exception err) {
                       log.warn("messageReceived({}) failed ({}) to signal {}[{}] on channel={}: {}",
                           session, err.getClass().getSimpleName(), e.getClass().getSimpleName(),
                           e.getMessage(), channel, err.getMessage());
                   }
               };
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org