You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/09/20 22:39:50 UTC
[GitHub] spark pull request #22505: Revert "[SPARK-23715][SQL] the input of to/from_u...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22505
Revert "[SPARK-23715][SQL] the input of to/from_utc_timestamp can not have timezone
## What changes were proposed in this pull request?
This reverts commit 417ad92502e714da71552f64d0e1257d2fd5d3d0.
We decided to keep the current behaviors unchanged and will consider whether we will deprecate the these functions in 3.0.
## How was this patch tested?
The existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark revertSpark-23715
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22505.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22505
----
commit 3908b98564a72500100a0b76466b9abf48cb9cb7
Author: gatorsmile <ga...@...>
Date: 2018-09-20T22:36:17Z
Revert "[SPARK-23715][SQL] the input of to/from_utc_timestamp can not have timezone"
This reverts commit 417ad92502e714da71552f64d0e1257d2fd5d3d0.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/22505
lgtm - let's make sure tests pass
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22505: Revert "[SPARK-23715][SQL] the input of to/from_u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22505
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96385/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22505
thanks, merging to master/2.4!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22505
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3314/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22505
**[Test build #96385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96385/testReport)** for PR 22505 at commit [`3908b98`](https://github.com/apache/spark/commit/3908b98564a72500100a0b76466b9abf48cb9cb7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22505
**[Test build #96385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96385/testReport)** for PR 22505 at commit [`3908b98`](https://github.com/apache/spark/commit/3908b98564a72500100a0b76466b9abf48cb9cb7).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22505
cc @rxin @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22505: Revert "[SPARK-23715][SQL] the input of to/from_utc_time...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22505
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org