You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/06/09 09:10:21 UTC
[jira] [Commented] (WICKET-6178) MetaDataHeaderItem #
generateString() should return specials characters escaped like
StringEscapeUtils.escapeHtml(s) does
[ https://issues.apache.org/jira/browse/WICKET-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322202#comment-15322202 ]
ASF subversion and git services commented on WICKET-6178:
---------------------------------------------------------
Commit f0e47c3447b5568923bb5b673c66c88d4c81efcc in wicket's branch refs/heads/wicket-7.x from [~bitstorm]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f0e47c3 ]
WICKET-6178 MetaDataHeaderItem # generateString() should return specials
characters escaped like StringEscapeUtils.escapeHtml(s) does
> MetaDataHeaderItem # generateString() should return specials characters escaped like StringEscapeUtils.escapeHtml(s) does
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-6178
> URL: https://issues.apache.org/jira/browse/WICKET-6178
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 7.3.0
> Reporter: francois
> Assignee: Andrea Del Bene
> Priority: Minor
>
> I think MetaDataHeaderItem # generateString() should return specials characters escaped like
> StringEscapeUtils.escapeHtml(s) does.
> Apache Wicket 7.3.0 - MetaDataHeaderItem - Line 126 : append(JavaScriptUtils.escapeQuotes(value.toString()))
> return qwerty'qwerty as qwerty\’qwerty
> I would like the return to be qwerty'qwerty (for example for the metatag description).
> Martin's answer :
> Looking at
> https://github.com/apache/wicket/blob/39fb20b112e2005dab8e17667e5a763b1d89f18e/wicket-core/src/main/java/org/apache/wicket/markup/head/MetaDataHeaderItem.java#L125-L127
> I agree that only double quotes should be escaped because only double
> quotes may end prematurely the value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)