You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Gary-Hobson (via GitHub)" <gi...@apache.org> on 2023/08/09 07:35:13 UTC
[GitHub] [nuttx] Gary-Hobson opened a new pull request, #10124: Noteram
Gary-Hobson opened a new pull request, #10124:
URL: https://github.com/apache/nuttx/pull/10124
## Summary
This PR moves the note formatting code from trace_dump into noteram and simplifies the noteram code.
Details:
Change 1: move trace_dump to noteram_driver.c
Change 2: replace the spaces in the name in tcb, there cannot be spaces in the thread name in atrace format
Change 3: remove task_context and get_taskname related code, we don't need it anymore
Change 4: simplify the logic of ringbuffer in noteram
## Impact
The data returned by reading the /dev/note device is no longer binary data, but a formatted string, and it will only return one note record each time it is read
## Testing
self-test + internal CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on pull request #10124: drivers/note: move the note formatting code from trace_dump into noteram_drivers.c
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson commented on PR #10124:
URL: https://github.com/apache/nuttx/pull/10124#issuecomment-1674147973
> Please fix this error in the nuttx-apps:
>
I've already fixed the error in the nuttx-apps：https://github.com/apache/nuttx-apps/pull/1942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #10124: drivers/note: move the note formatting code from trace_dump into noteram_drivers.c
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10124:
URL: https://github.com/apache/nuttx/pull/10124#issuecomment-1673790778
Please fix this error in the nuttx-apps:
```
====================================================================================
Configuration/Tool: esp32-devkitc/watcher
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
In file included from wdt.c:38:
Error: task_mn.h:74:35: error: 'struct noteram_get_taskname_s' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
74 | void task_mn_get_task_name(struct noteram_get_taskname_s *task);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [/github/workspace/sources/apps/Application.mk:171: wdt.c.github.workspace.sources.apps.examples.watcher.o] Error 1
In file included from task_mn.c:37:
Error: task_mn.h:74:35: error: 'struct noteram_get_taskname_s' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
74 | void task_mn_get_task_name(struct noteram_get_taskname_s *task);
| ^~~~~~~~~~~~~~~~~~~~~~
task_mn.c: In function 'task_mn_print_tasks_status':
Error: task_mn.c:65:33: error: storage size of 'task' isn't known
65 | struct noteram_get_taskname_s task;
| ^~~~
Error: task_mn.c:86:25: error: 'NOTERAM_GETTASKNAME' undeclared (first use in this function); did you mean 'NOTERAM_GETMODE'?
86 | ioctl(notefd, NOTERAM_GETTASKNAME, (unsigned long)&task);
| ^~~~~~~~~~~~~~~~~~~
| NOTERAM_GETMODE
task_mn.c:86:25: note: each undeclared identifier is reported only once for each function it appears in
Error: task_mn.c:65:33: error: unused variable 'task' [-Werror=unused-variable]
65 | struct noteram_get_taskname_s task;
| ^~~~
task_mn.c: At top level:
Error: task_mn.c:244:35: error: 'struct noteram_get_taskname_s' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
244 | void task_mn_get_task_name(struct noteram_get_taskname_s *task)
| ^~~~~~~~~~~~~~~~~~~~~~
Error: task_mn.c:244:6: error: conflicting types for 'task_mn_get_task_name'; have 'void(struct noteram_get_taskname_s *)'
244 | void task_mn_get_task_name(struct noteram_get_taskname_s *task)
| ^~~~~~~~~~~~~~~~~~~~~
task_mn.h:74:6: note: previous declaration of 'task_mn_get_task_name' with type 'void(struct noteram_get_taskname_s *)'
74 | void task_mn_get_task_name(struct noteram_get_taskname_s *task);
| ^~~~~~~~~~~~~~~~~~~~~
task_mn.c: In function 'task_mn_get_task_name':
Error: task_mn.c:255:17: error: 'NOTERAM_GETTASKNAME' undeclared (first use in this function); did you mean 'NOTERAM_GETMODE'?
255 | ioctl(notefd, NOTERAM_GETTASKNAME, (unsigned long)task);
| ^~~~~~~~~~~~~~~~~~~
| NOTERAM_GETMODE
task_mn.c: In function 'task_mn_subscribe':
Error: task_mn.c:261:33: error: storage size of 'task' isn't known
261 | struct noteram_get_taskname_s task;
| ^~~~
Error: task_mn.c:261:33: error: unused variable 'task' [-Werror=unused-variable]
task_mn.c: In function 'task_mn_unsubscribe':
Error: task_mn.c:281:33: error: storage size of 'task' isn't known
281 | struct noteram_get_taskname_s task;
| ^~~~
Error: task_mn.c:281:33: error: unused variable 'task' [-Werror=unused-variable]
cc1: all warnings being treated as errors
make[3]: *** [/github/workspace/sources/apps/Application.mk:171: task_mn.c.github.workspace.sources.apps.examples.watcher.o] Error 1
In file included from watcher_main.c:34:
Error: task_mn.h:74:35: error: 'struct noteram_get_taskname_s' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
74 | void task_mn_get_task_name(struct noteram_get_taskname_s *task);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [/github/workspace/sources/apps/Application.mk:231: watcher_main.c.github.workspace.sources.apps.examples.watcher.o] Error 1
make[3]: Target 'all' not remade because of errors.
make[2]: *** [Makefile:53: /github/workspace/sources/apps/examples/watcher_all] Error 2
make[2]: Target '/github/workspace/sources/apps/libapps.a' not remade because of errors.
make[1]: *** [Makefile:47: all] Error 2
make: *** [tools/LibTargets.mk:232: /github/workspace/sources/apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 370: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
Normalize esp32-devkitc/watcher
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #10124: drivers/note: move the note formatting code from trace_dump into noteram_drivers.c
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10124:
URL: https://github.com/apache/nuttx/pull/10124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org