You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mas-chen (via GitHub)" <gi...@apache.org> on 2023/04/25 22:32:55 UTC
[GitHub] [flink-connector-kafka] mas-chen opened a new pull request, #24: [FLINK-30859] Sync kafka related examples from apache/flink:master
mas-chen opened a new pull request, #24:
URL: https://github.com/apache/flink-connector-kafka/pull/24
There is only one example related to Kafka -- StateMachineExample.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #24: [FLINK-30859] Sync kafka related examples from apache/flink:master
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on code in PR #24:
URL: https://github.com/apache/flink-connector-kafka/pull/24#discussion_r1205609370
##########
flink-examples-kafka/flink-examples-streaming-state-machine-build-helper/src/main/resources/META-INF/NOTICE:
##########
@@ -0,0 +1,9 @@
+flink-examples-streaming-state-machine
+Copyright 2014-2023 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.kafka:kafka-clients:3.2.3
Review Comment:
the depended Kafka version is now 3.4.0
##########
flink-examples-kafka/pom.xml:
##########
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka-parent</artifactId>
+ <version>3.1-SNAPSHOT</version>
+ </parent>
+
+ <packaging>pom</packaging>
+
+ <artifactId>flink-examples-kafka</artifactId>
+ <name>Flink : Formats : Kafka</name>
Review Comment:
`Flink : Examples : Kafka`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] mas-chen closed pull request #24: [FLINK-30859] Sync kafka related examples from apache/flink:master
Posted by "mas-chen (via GitHub)" <gi...@apache.org>.
mas-chen closed pull request #24: [FLINK-30859] Sync kafka related examples from apache/flink:master
URL: https://github.com/apache/flink-connector-kafka/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] mas-chen commented on pull request #24: [FLINK-30859] Sync kafka related examples from apache/flink:master
Posted by "mas-chen (via GitHub)" <gi...@apache.org>.
mas-chen commented on PR #24:
URL: https://github.com/apache/flink-connector-kafka/pull/24#issuecomment-1593889326
Discussed offline to refactor to remove Kafka dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org