You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/03/15 05:09:09 UTC

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #850: ZOOKEEPER-3309: Add sync processor metrics

lvfangmin commented on a change in pull request #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r265851210
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
 ##########
 @@ -74,6 +74,16 @@
     CONNECTION_TOKEN_DEFICIT(new AvgMinMaxCounter("connection_token_deficit")),
     CONNECTION_REJECTED(new SimpleCounter("connection_rejected")),
 
+    SYNC_PROCESSOR_QUEUE_TIME(new AvgMinMaxPercentileCounter("sync_processor_queue_time_ms")),
+    SYNC_PROCESSOR_QUEUE_SIZE(new AvgMinMaxCounter("sync_processor_queue_size")),
+    SYNC_PROCESSOR_QUEUED(new SimpleCounter("sync_processor_request_queued")),
+    SYNC_PROCESSOR_REAL_QUEUE_TIME(new AvgMinMaxPercentileCounter("sync_processor_real_queue_time_ms")),
 
 Review comment:
   Let's remove this one, and change SYNC_PROCESSOR_QUEUE_TIME to track the real queue time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services