svn commit: r192987 - /spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm

[jm...@apache.org]

Author: jm
Date: Wed Jun 22 12:56:04 2005
New Revision: 192987

URL: http://svn.apache.org/viewcvs?rev=192987&view=rev
Log:
clarify; mbx separator is a binary blob of data, I don't think we do support that

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm?rev=192987&r1=192986&r2=192987&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm Wed Jun 22 12:56:04 2005
@@ -68,9 +68,8 @@
 entire message, an array reference of the message with 1 line per array
 element, or a file glob which holds the entire contents of the message.
 
-Note: The message is expected to generally be in RFC 2822 format,
-optionally including a mbox or mbx message separation line as the
-first line.
+Note: The message is expected to generally be in RFC 2822 format, optionally
+including an mbox message separator line (the "From " line) as the first line.
 
 C<parse_now> specifies whether or not to create the MIME tree
 at object-creation time or later as necessary.

Re: svn commit: r192987 - /spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm

[Theo Van Dinter <fe...@apache.org>]

On Wed, Jun 22, 2005 at 07:56:05PM -0000, jm@apache.org wrote:
> clarify; mbx separator is a binary blob of data, I don't think we do support that

Are we talking about the same mbx?  Had support for this since 3.0.0:

Constants.pm:
# regular expression that matches message separators in The University of
# Washington's MBX mailbox format
use constant MBX_SEPARATOR => qr/([\s|\d]\d-[a-zA-Z]{3}-\d{4}\s\d{2}:\d{2}:\d{2}.*),(\d+);([\da-f]{12})-(\w{8})/;

Message.pm:
[...]
  } elsif ($message[0] =~ MBX_SEPARATOR) {
    $_ = shift @message;
  
    # Munge the mbx message separator into mbox format as a sort of
    # de facto portability standard in SA's internals.  We need to
    # to this so that Mail::SpamAssassin::Util::parse_rfc822_date
    # can parse the date string...
    if (/([\s|\d]\d)-([a-zA-Z]{3})-(\d{4})\s(\d{2}):(\d{2}):(\d{2})/) {
      # $1 = day of month
[...]

-- 
Randomly Generated Tagline:
"It's flavorless, colorless, odorless ... It's a veritable ninja."
         - Alton Brown, The Art of Darkness, talking about Powdered Gelatin