[GitHub] [spark] Daniel-Davies edited a comment on pull request #35032: [SPARK-37738][PYTHON] Fix API skew in PySpark date functions

[GitBox <gi...@apache.org>]

Daniel-Davies edited a comment on pull request #35032:
URL: https://github.com/apache/spark/pull/35032#issuecomment-1002209640


   Great, thanks both- @zero323 let me know if there's anything else.
   
   I also have one other question; when is the Column type used vs ColumnOrName in function parameters? E.g., why are both types used in the following function?
   
   https://github.com/apache/spark/blob/master/python/pyspark/sql/functions.py#L3695
   
   Would it be worth converting some of the existing Column type inputs to use ColumnOrName?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org