You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/21 14:46:31 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7157: armv7-r/tms570: fix build break
anchao opened a new pull request, #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157
## Summary
armv7-r/tms570: fix build break
1.
`make[1]: *** No rule to make target 'tms570_spi.c', needed by '.depend'. Stop.`
2.
```
In file included from armv7-r/arm_gicv2.c:36:
armv7-r/gic.h: In function 'arm_gic_nlines':
armv7-r/mpcore.h:63:29: error: 'CHIP_MPCORE_VBASE' undeclared (first use in this function)
63 | #define MPCORE_ICD_VBASE (CHIP_MPCORE_VBASE+MPCORE_ICD_OFFSET)
| ^~~~~~~~~~~~~~~~~
```
Signed-off-by: chao an <an...@xiaomi.com>
## Impact
N/A
## Testing
armv7-r launchxl-tms57004/nsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976678887
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,6 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
Review Comment:
But it' too slow to rebuild the toolchain every time, we need find a prebuilt binary for ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976668790
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,6 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
Review Comment:
The problem is that we can't find the prebuilt toolchain which ship with the big endian library. @acassis can you find one? @anchao can enable tms570 in Ci, if you can fine one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976657405
##########
arch/arm/src/tms570/Make.defs:
##########
@@ -23,7 +23,7 @@ include armv7-r/Make.defs
# SAMA5-specific C source files
CHIP_CSRCS = tms570_boot.c tms570_clockconfig.c tms570_esm.c tms570_gio.c
-CHIP_CSRCS += tms570_irq.c tms570_lowputc.c tms570_serial.c tms570_spi.c
Review Comment:
Why to remove tms570_spi.c ?
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,6 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
Review Comment:
I think TMS570 is the only Arch on NuttX that supports Big Endian, it should be a nice platform to verify if there are issues in the system and/or drivers. Is the big-endian passed in other place now or it will assume that ARCH will be little-endian?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976676954
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,6 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
Review Comment:
@xiaoxiang781216 according with README.txt Greg used buildroot to build one:
```
Endian-ness Issues
------------------
I used a version of the NuttX buildroot toolchain that can be built like
this:
cd buildroot/
cp boards/cortexr4f-eabi-defconfig-4.8.5 .config
make oldconfig
make
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976684332
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,6 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
Review Comment:
The config still exist: https://bitbucket.org/nuttx/buildroot/src/master/configs/ so we can build it. I will try to find the board to buy and test it. Seems it still available on ti.com website
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976667047
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,6 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
Review Comment:
big endian is handled in Toolchain.defs:
https://github.com/apache/incubator-nuttx/pull/7154/files#diff-e783502fea920bef2c55bc9acca1879335a27dab6df70ee9bae662e702a44357L90-R116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976634512
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,7 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
+ARCHCPUFLAGS = -mcpu=cortex-r4
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976672891
##########
arch/arm/src/tms570/Make.defs:
##########
@@ -23,7 +23,7 @@ include armv7-r/Make.defs
# SAMA5-specific C source files
CHIP_CSRCS = tms570_boot.c tms570_clockconfig.c tms570_esm.c tms570_gio.c
-CHIP_CSRCS += tms570_irq.c tms570_lowputc.c tms570_serial.c tms570_spi.c
Review Comment:
Ok, I saw the issue. I think @patacongo added support to SPI on TMS570 but missed to include the tms570_spi.c inside arch/, there is only tms570_spi.c inside board. Initially I thought someone had removed this file, but then I searched on all my NuttX backup files and didn't find it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7157: armv7-r/tms570: fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976610553
##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,7 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = flash-sram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian
+ARCHCPUFLAGS = -mcpu=cortex-r4
Review Comment:
let's move cortex-r4 to Toolchain.defs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org