[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342548#comment-14342548 ] 

ASF GitHub Bot commented on CB-8577:
------------------------------------

Github user gorkem commented on the pull request:

    https://github.com/apache/cordova-lib/pull/174#issuecomment-76639381
  
    Ahhh. I see what you mean now. I think we should fix this on the Config.getFeature(id) so that the existing information on config.xml files are not discarded. 


> 'cordova plugin add <plugin> --save' should save variables into config.xml
> --------------------------------------------------------------------------
>
>                 Key: CB-8577
>                 URL: https://issues.apache.org/jira/browse/CB-8577
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Omar Mefire
>
> When adding a plugin with the --save/autosave option on, the variables (if any is passed) should be saved into config.xml so that the plugin can be auto-restored successfully later during 'prepare' or 'build' operation.
> For example:
> - cordova create hello com.omefire.hello Hello
> - cd hello
> - cordova plugin add com.phonegap.plugins.facebookconnect --variable APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in facebook plugin added to config.xml
> - cordova prepare android => results in an error message :
> " Installing "com.phonegap.plugins.facebookconnect" for android
> Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) missing: APP_ID, APP_NAME "
> This issue is due to the fact that 'cordova plugin add <plugin> --save' save variables in config.xml using the <param> tag instead of the <variable> tag.
> N.B: on 'cordova prepare <platform>', the plugins are restored from config.xml if they are not yet installed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org