[GitHub] style95 commented on issue #32: Add environment variables for cluster

[gi...@git.apache.org]

style95 commented on issue #32: Add environment variables for cluster
URL: https://github.com/apache/couchdb-docker/pull/32#issuecomment-333006534
 
 
   I am not sure those parameters will be deprecated, but it seems they are not yet deprecated as we can find them in the documentation.
   http://docs.couchdb.org/en/2.1.0/cluster/theory.html
   
   Even we can override default parameters by specifying those parameters in query.
   https://github.com/apache/couchdb/tree/master/src/mango#find
   
   This pr is just to support the case that someone want to configure those values but doesn't want to mount configuration directory.
   It took similar way which is applied for `$COUCHDB_USER` and `$COUCHDB_PASSWORD`.
   (https://github.com/apache/couchdb-docker/pull/32/files#diff-1fc2ace1a535d6dbd28b7b88eb11a853R41)
   
   This could frequently happen because user can run CouchDB cluster with a single docker command.
   Without this changes, user can run standalone couchDB with single `docker run` command, but cannot run CouchDB cluster without volume mapping.
   
   WRT, overriding of default values, what is the preferable ways?
   Since `/opt/couchdb/etc/local.d/*` has the highest priority, I put them there.
   Configurations reside in other places such as `etc/default.ini`, `etc/default.d/*.ini`, `etc/local.ini` will be overridden by those in `/opt/couchdb/etc/local.d/*`.
   (http://docs.couchdb.org/en/2.1.0/config/intro.html#configuration-files)
   
   If this is not desired approach, kindly let me know, I can amend the commit at any times.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services