You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/12/09 14:07:45 UTC
[GitHub] [orc] deshanxiao opened a new pull request, #1337: ORC-1330: Add test for OrcConf
deshanxiao opened a new pull request, #1337:
URL: https://github.com/apache/orc/pull/1337
### What changes were proposed in this pull request?
This PR is aimed to add a test for OrcConf.
### Why are the changes needed?
To Improve test coverage.
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1337: ORC-1330: Add test for OrcConf
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1337:
URL: https://github.com/apache/orc/pull/1337#discussion_r1044724128
##########
java/core/src/test/org/apache/orc/TestOrcConf.java:
##########
@@ -0,0 +1,125 @@
+package org.apache.orc;
+
+import org.apache.hadoop.conf.Configuration;
+import org.junit.jupiter.api.Test;
+
+import java.util.Properties;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class TestOrcConf {
+
+ // Long
+ public final OrcConf ORC_STRIPE_SIZE_CONF = OrcConf.STRIPE_SIZE;
Review Comment:
Use 2-space indentation please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1337: ORC-1330: Add `TestOrcConf`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1337:
URL: https://github.com/apache/orc/pull/1337#issuecomment-1344992605
Merged to main/1.8. Thank you, @deshanxiao .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1337: ORC-1330: Add `TestOrcConf`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1337: ORC-1330: Add `TestOrcConf`
URL: https://github.com/apache/orc/pull/1337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1337: ORC-1330: Add test for OrcConf
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1337:
URL: https://github.com/apache/orc/pull/1337#issuecomment-1344354386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on a diff in pull request #1337: ORC-1330: Add test for OrcConf
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on code in PR #1337:
URL: https://github.com/apache/orc/pull/1337#discussion_r1044948250
##########
java/core/src/test/org/apache/orc/TestOrcConf.java:
##########
@@ -0,0 +1,125 @@
+package org.apache.orc;
+
+import org.apache.hadoop.conf.Configuration;
+import org.junit.jupiter.api.Test;
+
+import java.util.Properties;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class TestOrcConf {
+
+ // Long
+ public final OrcConf ORC_STRIPE_SIZE_CONF = OrcConf.STRIPE_SIZE;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org