You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/01 12:56:03 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on a change in pull request #8637: [Feature-8612][RESOURCE] extend s3 to the storage of ds

zhongjiajie commented on a change in pull request #8637:
URL: https://github.com/apache/dolphinscheduler/pull/8637#discussion_r816742440



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java
##########
@@ -496,6 +464,7 @@ public Result createUdfFunc(@ApiIgnore @RequestAttribute(value = Constants.SESSI
                                 @RequestParam(value = "database", required = false) String database,
                                 @RequestParam(value = "description", required = false) String description,
                                 @PathVariable(value = "resourceId") int resourceId) {
+        //todo verify the sourceName

Review comment:
       Why we need `todo` here? Does this WIP?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org