You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/02/18 00:21:36 UTC

[GitHub] [helix] desaikomal commented on a change in pull request #1964: Code cleanup: addListenersToController is not used at all

desaikomal commented on a change in pull request #1964:
URL: https://github.com/apache/helix/pull/1964#discussion_r809577839



##########
File path: helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java
##########
@@ -130,24 +130,6 @@ public static CommandLine processCommandLineArgs(String[] cliArgs) throws Except
     return null;
   }
 
-  public static void addListenersToController(HelixManager manager,

Review comment:
       that is why in description section for backward compatibility, i have written:
   > This is a public method of - helix/helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java
   
   method signature is: public static void addListenersToController(HelixManager manager, GenericHelixController controller)
   
   Please do look at and see if there are any consumers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org