[GitHub] [nifi] markap14 commented on a change in pull request #5514: NIFI-9069: Changed framework so that it serializes the dataflow into …

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #5514:
URL: https://github.com/apache/nifi/pull/5514#discussion_r752414783



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/flow/PopularVoteFlowElection.java
##########
@@ -141,7 +142,7 @@ public synchronized DataFlow castVote(final DataFlow candidate, final NodeIdenti
     }
 
     private String fingerprint(final DataFlow dataFlow) {
-        final String flowFingerprint = fingerprintFactory.createFingerprint(dataFlow.getFlow());
+        final String flowFingerprint = DigestUtils.sha256Hex(dataFlow.getFlow());

Review comment:
       We can definitely remove the instance from this class. The class is still used elsewhere, though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org