You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/06 00:02:48 UTC

[GitHub] [flink] bowenli86 commented on a change in pull request #8639: [FLINK-12756][hive] migrate HiveCatalog from TypeInformation-based old type system to DataType-based new type system

bowenli86 commented on a change in pull request #8639: [FLINK-12756][hive] migrate HiveCatalog from TypeInformation-based old type system to DataType-based new type system
URL: https://github.com/apache/flink/pull/8639#discussion_r290980052
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
 ##########
 @@ -317,6 +317,20 @@ public Builder field(String name, DataType dataType) {
 			return this;
 		}
 
+		/**
+		 * Add an array of fields with names and data types.
+		 *
+		 * <p>The call order of this method determines the order of fields in the schema.
+		 */
+		public Builder fields(String[] names, DataType[] dataTypes) {
 
 Review comment:
   Note that the builder is already there, and is not introduced by this PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services