You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2021/05/14 12:21:59 UTC

[GitHub] [ambari] martin-g opened a new pull request #3310: AMBARI-20534 AMBARI-25607 Replace PhantomJS with Google Chrome

martin-g opened a new pull request #3310:
URL: https://github.com/apache/ambari/pull/3310


   ## What changes were proposed in this pull request?
   
   This PR is built on top of https://github.com/apache/ambari/pull/3309.
   In addition it replaces the not maintained PhantomJS for JS unit tests with headless Google Chrome.
   
   ## How was this patch tested?
   
   `ambari-web$ mvn test` runs fine on both Linux x86_64 and aarch64. 
   There are 15 failing tests which I will try to debug now. 
   For the record there are 5 failing tests in current `trunk`!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] martin-g commented on pull request #3310: AMBARI-20534 AMBARI-25607 Replace PhantomJS with Google Chrome

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #3310:
URL: https://github.com/apache/ambari/pull/3310#issuecomment-842280604


   All JavaScript unit tests in ambari-web module are fixed now!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] martin-g commented on pull request #3310: AMBARI-20534 AMBARI-25607 Replace PhantomJS with Google Chrome

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #3310:
URL: https://github.com/apache/ambari/pull/3310#issuecomment-845953093


   Closing in favour of #3312 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] martin-g commented on pull request #3310: AMBARI-20534 AMBARI-25607 Replace PhantomJS with Google Chrome

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #3310:
URL: https://github.com/apache/ambari/pull/3310#issuecomment-842280604


   All JavaScript unit tests in ambari-web module are fixed now!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] martin-g closed pull request #3310: AMBARI-20534 AMBARI-25607 Replace PhantomJS with Google Chrome

Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #3310:
URL: https://github.com/apache/ambari/pull/3310


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] martin-g commented on pull request #3310: AMBARI-20534 AMBARI-25607 Replace PhantomJS with Google Chrome

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #3310:
URL: https://github.com/apache/ambari/pull/3310#issuecomment-843111196


   I've also updated TestContainers to 1.15.3 (latest release at the moment) - it uses JNA 5.8.0 which provides fixes for Linux/AMR64 and initial support for MacOS/ARM64.
   Added an assumption for MySQL because there are only linux/amd64 Docker images at DockerHub.
   
   With this the whole test suite passes on Linux/ARM64 !
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org