You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2020/12/03 04:55:50 UTC
Review Request 73058: ATLAS-4057 : DSL Search : Support glossary terms
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'with' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search:**
hive_table with "modernTrade@salesGlossary",
hive_table with "modernTrade@salesGlossary" and hive_table isA Dimension
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
Diff: https://reviews.apache.org/r/73058/diff/1/
Testing
-------
Added testcases in DSLQueriesTest.java
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
> On Dec. 3, 2020, 5:58 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
> > Lines 208 (patched)
> > <https://reviews.apache.org/r/73058/diff/2/?file=2242677#file2242677line217>
> >
> > This doesn't make senese.
this has been used in DSLVisitor#241 to modify query accordingly.
if it is non primitive (relationship or glossary), add attribute inside and() condition, to avoid traversing back to the original vertex.
Example:
hive_table where db.name = "sales";
original query:
g.V().has("__typeName", 'hive_Table').out('__hive_table.db').has('Asset.__s_name', eq('product_id')).dedup().in('__Table.db').dedup().limit(25).toList()
Current query:
g.V().has('__typeName', 'hive_table').and(__.out('__hive_table.db').has('Asset.__s_name', eq('product_id')).dedup()).dedup().limit(25).toList()
> On Dec. 3, 2020, 5:58 p.m., Ashutosh Mestry wrote:
> > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
> > Line 102 (original), 102 (patched)
> > <https://reviews.apache.org/r/73058/diff/2/?file=2242687#file2242687line102>
> >
> > Can you please include a test that verifies the genreated gremlin query?
yes sure
> On Dec. 3, 2020, 5:58 p.m., Ashutosh Mestry wrote:
> > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
> > Line 190 (original), 190 (patched)
> > <https://reviews.apache.org/r/73058/diff/2/?file=2242687#file2242687line190>
> >
> > What is the reason for these queries changing?
Refer above comment
- Pinal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222281
-----------------------------------------------------------
On Dec. 3, 2020, 6:05 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2020, 6:05 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'with' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search:**
>
> hive_table with "modernTrade@salesGlossary",
>
> hive_table with "modernTrade@salesGlossary" and hive_table isA Dimension
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/4/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/245/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
> On Dec. 3, 2020, 5:58 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
> > Lines 208 (patched)
> > <https://reviews.apache.org/r/73058/diff/2/?file=2242677#file2242677line217>
> >
> > This doesn't make senese.
>
> Pinal Shah wrote:
> this has been used in DSLVisitor#241 to modify query accordingly.
> if it is non primitive (relationship or glossary), add attribute inside and() condition, to avoid traversing back to the original vertex.
>
> Example:
> hive_table where db.name = "sales";
>
> original query:
> g.V().has("__typeName", 'hive_Table').out('__hive_table.db').has('Asset.__s_name', eq('product_id')).dedup().in('__Table.db').dedup().limit(25).toList()
>
> Current query:
> g.V().has('__typeName', 'hive_table').and(__.out('__hive_table.db').has('Asset.__s_name', eq('product_id')).dedup()).dedup().limit(25).toList()
Got it! Thanks!
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222281
-----------------------------------------------------------
On Dec. 4, 2020, 1:37 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2020, 1:37 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/5/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/245/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222281
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java
Lines 195 (patched)
<https://reviews.apache.org/r/73058/#comment311344>
Remove this line.
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
Lines 208 (patched)
<https://reviews.apache.org/r/73058/#comment311345>
This doesn't make senese.
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java
Lines 202 (patched)
<https://reviews.apache.org/r/73058/#comment311340>
Good!
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
Line 102 (original), 102 (patched)
<https://reviews.apache.org/r/73058/#comment311342>
Can you please include a test that verifies the genreated gremlin query?
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
Line 190 (original), 190 (patched)
<https://reviews.apache.org/r/73058/#comment311343>
What is the reason for these queries changing?
- Ashutosh Mestry
On Dec. 3, 2020, 6:05 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2020, 6:05 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'with' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search:**
>
> hive_table with "modernTrade@salesGlossary",
>
> hive_table with "modernTrade@salesGlossary" and hive_table isA Dimension
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/4/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/245/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Jan. 14, 2021, 6:40 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
rebase trailing whitespaces
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'hasTerm' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search with term:**
hive_table hasTerm "modernTrade@salesGlossary",
hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
**Example queries to search with relationship:**
hive_table where db.name = "sales"
Diffs (updated)
-----
docs/src/documents/Search/SearchAdvanced.md 46be14278
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
Diff: https://reviews.apache.org/r/73058/diff/10/
Changes: https://reviews.apache.org/r/73058/diff/9-10/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222468
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 13, 2021, 4:31 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2021, 4:31 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search with term:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
> **Example queries to search with relationship:**
>
> hive_table where db.name = "sales"
>
>
> Diffs
> -----
>
> docs/src/documents/Search/SearchAdvanced.md 46be14278
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/9/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Jan. 13, 2021, 12:31 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
added documentation
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'hasTerm' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search with term:**
hive_table hasTerm "modernTrade@salesGlossary",
hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
**Example queries to search with relationship:**
hive_table where db.name = "sales"
Diffs (updated)
-----
docs/src/documents/Search/SearchAdvanced.md 46be14278
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
Diff: https://reviews.apache.org/r/73058/diff/9/
Changes: https://reviews.apache.org/r/73058/diff/8-9/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
> On Jan. 12, 2021, 8:20 p.m., Sarath Subramanian wrote:
> > docs/src/documents/Search/SearchAdvanced.md
> > Lines 228 (patched)
> > <https://reviews.apache.org/r/73058/diff/8/?file=2244142#file2244142line228>
> >
> > can we add a new section and examples for relationship search?
okay, i will add new section specifically for relationship
- Pinal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222445
-----------------------------------------------------------
On Jan. 12, 2021, 11:54 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2021, 11:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search with term:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
> **Example queries to search with relationship:**
>
> hive_table where db.name = "sales"
>
>
> Diffs
> -----
>
> docs/src/documents/Search/SearchAdvanced.md 46be14278
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/8/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222445
-----------------------------------------------------------
docs/src/documents/Search/SearchAdvanced.md
Lines 228 (patched)
<https://reviews.apache.org/r/73058/#comment311500>
can we add a new section and examples for relationship search?
- Sarath Subramanian
On Jan. 12, 2021, 3:54 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2021, 3:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search with term:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
> **Example queries to search with relationship:**
>
> hive_table where db.name = "sales"
>
>
> Diffs
> -----
>
> docs/src/documents/Search/SearchAdvanced.md 46be14278
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/8/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
> On Jan. 12, 2021, 5:44 p.m., Ashutosh Mestry wrote:
> > Can you please update documentation with these new keywords?
Nevermind, i see it. Thanks!
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222443
-----------------------------------------------------------
On Jan. 12, 2021, 11:54 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2021, 11:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search with term:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
> **Example queries to search with relationship:**
>
> hive_table where db.name = "sales"
>
>
> Diffs
> -----
>
> docs/src/documents/Search/SearchAdvanced.md 46be14278
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/8/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222443
-----------------------------------------------------------
Can you please update documentation with these new keywords?
- Ashutosh Mestry
On Jan. 12, 2021, 11:54 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2021, 11:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search with term:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
> **Example queries to search with relationship:**
>
> hive_table where db.name = "sales"
>
>
> Diffs
> -----
>
> docs/src/documents/Search/SearchAdvanced.md 46be14278
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/8/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Jan. 12, 2021, 11:54 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
added doc
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'hasTerm' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search with term:**
hive_table hasTerm "modernTrade@salesGlossary",
hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
**Example queries to search with relationship:**
hive_table where db.name = "sales"
Diffs (updated)
-----
docs/src/documents/Search/SearchAdvanced.md 46be14278
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
Diff: https://reviews.apache.org/r/73058/diff/8/
Changes: https://reviews.apache.org/r/73058/diff/7-8/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Jan. 12, 2021, 10:53 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
addressed - nit: imports
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'hasTerm' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search with term:**
hive_table hasTerm "modernTrade@salesGlossary",
hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
**Example queries to search with relationship:**
hive_table where db.name = "sales"
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 36b514e84
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
Diff: https://reviews.apache.org/r/73058/diff/7/
Changes: https://reviews.apache.org/r/73058/diff/6-7/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222334
-----------------------------------------------------------
Can you please add a small section on docs?
- Ashutosh Mestry
On Dec. 14, 2020, 9:56 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2020, 9:56 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search with term:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
> **Example queries to search with relationship:**
>
> hive_table where db.name = "sales"
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/6/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222439
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
Lines 28 (patched)
<https://reviews.apache.org/r/73058/#comment311496>
nit: review unused imports and avoid wilcard imports
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java
Line 7 (original), 6 (patched)
<https://reviews.apache.org/r/73058/#comment311495>
avoid wildcard imports and review and remove unused imports
- Sarath Subramanian
On Dec. 14, 2020, 1:56 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73058/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2020, 1:56 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4057
> https://issues.apache.org/jira/browse/ATLAS-4057
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
>
>
> **WorkAround:**
>
> 'hasTerm' keyword is added to support glossary term.
>
> User needs to add fully qualifiedName of glossary term.
>
>
>
> **Example queries to search with term:**
>
> hive_table hasTerm "modernTrade@salesGlossary",
>
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>
> **Example queries to search with relationship:**
>
> hive_table where db.name = "sales"
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
> repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
>
>
> Diff: https://reviews.apache.org/r/73058/diff/6/
>
>
> Testing
> -------
>
> Added testcases in DSLQueriesTest.java
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms and relationship
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Dec. 14, 2020, 9:56 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Summary (updated)
-----------------
ATLAS-4057 : DSL Search : Support glossary terms and relationship
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description (updated)
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'hasTerm' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search with term:**
hive_table hasTerm "modernTrade@salesGlossary",
hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
**Example queries to search with relationship:**
hive_table where db.name = "sales"
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
Diff: https://reviews.apache.org/r/73058/diff/6/
Changes: https://reviews.apache.org/r/73058/diff/5-6/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/245/
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Dec. 4, 2020, 1:37 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Addressed comments
Replaced 'with' keyword with 'hasTerm'
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description (updated)
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'hasTerm' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search:**
hive_table hasTerm "modernTrade@salesGlossary",
hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
Diff: https://reviews.apache.org/r/73058/diff/5/
Changes: https://reviews.apache.org/r/73058/diff/4-5/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/245/
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Dec. 3, 2020, 6:05 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
fixed test
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'with' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search:**
hive_table with "modernTrade@salesGlossary",
hive_table with "modernTrade@salesGlossary" and hive_table isA Dimension
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 487cf2778
Diff: https://reviews.apache.org/r/73058/diff/2/
Changes: https://reviews.apache.org/r/73058/diff/1-2/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/240/
Thanks,
Pinal Shah
Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary
terms
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Dec. 3, 2020, 4:58 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the entities which are assigned to particular glossary term.
**WorkAround:**
'with' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search:**
hive_table with "modernTrade@salesGlossary",
hive_table with "modernTrade@salesGlossary" and hive_table isA Dimension
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 249381059
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java 3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
Diff: https://reviews.apache.org/r/73058/diff/1/
Testing (updated)
-------
Added testcases in DSLQueriesTest.java
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/240/
Thanks,
Pinal Shah