[jira] [Commented] (CB-9249) Fix iOS warnings in Media Capture plugin

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726398#comment-14726398 ] 

ASF GitHub Bot commented on CB-9249:
------------------------------------

GitHub user macdonst opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/41

    CB-9249 Fix iOS warnings in Media Capture plugin

    Needs a code review.
    
    This removes the compiler warnings in Xcode.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/macdonst/cordova-plugin-media-capture master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit b69b142136d7d80ed43cd6db0c96fa0a5e18483b
Author: Simon MacDonald <si...@gmail.com>
Date:   2015-09-01T22:59:15Z

    CB-9249 Fix iOS warnings in Media Capture plugin

----


> Fix iOS warnings in Media Capture plugin
> ----------------------------------------
>
>                 Key: CB-9249
>                 URL: https://issues.apache.org/jira/browse/CB-9249
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Media Capture
>         Environment: Xcode 6.3.2
>            Reporter: Shazron Abdullah
>            Assignee: Simon MacDonald
>              Labels: cordova-ios-4.0.x
>
> {code}
> CDVCapture.m:519:19: warning: 
>       incompatible pointer types initializing 'NSString *__strong' with an expression of type 'CGPathRef'
>       (aka 'const struct CGPath *') [-Wincompatible-pointer-types]
>         NSString* moviePath = [[info objectForKey:UIImagePickerControllerMediaURL] path];
>                   ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~CDVCapture.m:819:60: warning: 
>       comparison of address of 'UIAccessibilityAnnouncementNotification' not equal to a null pointer is always true
>       [-Wtautological-pointer-compare]
>         BOOL isUIAccessibilityAnnouncementNotification = (&UIAccessibilityAnnouncementNotification != NULL);
>                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~    ~~~~
> 2 warnings generated.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org