svn commit: r1450129 - /jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/RepositoryImpl.java

[an...@apache.org]

Author: angela
Date: Tue Feb 26 10:59:49 2013
New Revision: 1450129

URL: http://svn.apache.org/r1450129
Log:
minor improvement: add annotations

Modified:
    jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/RepositoryImpl.java

Modified: jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/RepositoryImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/RepositoryImpl.java?rev=1450129&r1=1450128&r2=1450129&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/RepositoryImpl.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/RepositoryImpl.java Tue Feb 26 10:59:49 2013
@@ -17,7 +17,8 @@
 package org.apache.jackrabbit.oak.jcr;
 
 import java.util.concurrent.ScheduledExecutorService;
-
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
 import javax.jcr.Credentials;
 import javax.jcr.Repository;
 import javax.jcr.RepositoryException;
@@ -44,15 +45,12 @@ public class RepositoryImpl implements R
 
     private final Descriptors descriptors = new Descriptors(new SimpleValueFactory());
     private final ContentRepository contentRepository;
-
     private final ScheduledExecutorService executor;
-
     private final SecurityProvider securityProvider;
 
-    public RepositoryImpl(
-            ContentRepository contentRepository,
-            ScheduledExecutorService executor,
-            SecurityProvider securityProvider) {
+    public RepositoryImpl(@Nonnull ContentRepository contentRepository,
+                          @Nonnull ScheduledExecutorService executor,
+                          @Nonnull SecurityProvider securityProvider) {
         this.contentRepository = contentRepository;
         this.executor = executor;
         this.securityProvider = securityProvider;
@@ -119,8 +117,7 @@ public class RepositoryImpl implements R
      * @see javax.jcr.Repository#login(javax.jcr.Credentials, String)
      */
     @Override
-    public Session login(Credentials credentials, String workspaceName) throws RepositoryException {
-        // TODO: needs complete refactoring
+    public Session login(@Nullable Credentials credentials, @Nullable String workspaceName) throws RepositoryException {
         try {
             ContentSession contentSession = contentRepository.login(credentials, workspaceName);
             return new SessionDelegate(this, executor, contentSession, securityProvider, false).getSession();