[Bug 57055] New: CheckDirty.doAction should clear previousGuiItems for SUB_TREE_SAVED

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57055

            Bug ID: 57055
           Summary: CheckDirty.doAction should clear previousGuiItems for
                    SUB_TREE_SAVED
           Product: JMeter
           Version: 2.11
          Hardware: PC
                OS: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: sebb@apache.org

The code for CheckDirty.doAction(SUB_TREE_SAVED) looks odd.

It calls subTree.traverse(this) which calls previousGuiItems.put() for each
node. This would appear to add the whole tree to the map.

I suspect this works because the put() will replace any entries with the same
key.

However, if the previousGuiItems map contains any stale entries, they won't be
removed.

I would have expected the code to clear the map before repopulating it.
This will then catch any errors that may have crept in.

-- 
You are receiving this mail because:
You are the assignee for the bug.