You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Ubospica (via GitHub)" <gi...@apache.org> on 2023/04/11 10:57:32 UTC

[GitHub] [tvm] Ubospica opened a new pull request, #14581: [Unity] Update legalizer for variance

Ubospica opened a new pull request, #14581:
URL: https://github.com/apache/tvm/pull/14581

   Now the legalization method for relax.variance is:
   ```
   var(x) = mean((x - mean(x)) ** 2)
   ```
   This PR changes the legalization method into
   ```
   var(x) = mean(x * x) - mean(x) ** 2
   ```
   for better data locality (which means better performance)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #14581: [Unity] Update legalizer for variance

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14581:
URL: https://github.com/apache/tvm/pull/14581#issuecomment-1503244390

   there might be some numerical stability issues here, so would be good to put this on hold a bit and come and visit later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14581: [Unity] Update legalizer for variance

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14581:
URL: https://github.com/apache/tvm/pull/14581#issuecomment-1503109994

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen closed pull request #14581: [Unity] Update legalizer for variance

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed pull request #14581: [Unity] Update legalizer for variance
URL: https://github.com/apache/tvm/pull/14581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org