[GitHub] [cordova-plugin-geolocation] breautek edited a comment on issue #164: In-app prompt to open location services and authorizations

[GitBox <gi...@apache.org>]

breautek edited a comment on issue #164: In-app prompt to open location services and authorizations
URL: https://github.com/apache/cordova-plugin-geolocation/issues/164#issuecomment-541273339
 
 
   I understand what you're saying but I think extending the plugin to deal with user settings is out of scope of this plugin. Plugins should have one responsibility and do that one thing well. In this case, the plugin should handle receiving GPS positions upon requests.
   
   Additionally in my experience, at least for android, setting screens are not standardised. Different flavours of android from different phone manufacturers can have different setting screens. Which makes it very difficult to have a feature that brings a user directly to a settings screen, and for it to work as expected across all android devices.
   
   So adding APIs in this plugin to open up the GPS settings screen is something I would down vote on. Something like that makes more sense to be its own plugin in my opinion, and it makes more sense that plugin be more generic to open any screen, not just GPS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org