You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/18 10:59:08 UTC
[GitHub] [cordova-plugin-wkwebview-engine] timbru31 opened a new issue #133:
Enhance installation by inlining the configuration variables
timbru31 opened a new issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133
Inspired by [Niklas recent blog post](https://cordova.apache.org/howto/2020/03/18/wkwebviewonly.html), I'd like to discuss if we should inline the configuration variables to the plugin.xml:
```xml
<feature name="CDVWKWebViewEngine">
<param name="ios-package" value="CDVWKWebViewEngine" />
</feature>
<preference name="CordovaWebViewEngine" value="CDVWKWebViewEngine" />
```
Ionic's fork does this, too: https://github.com/ionic-team/cordova-plugin-ionic-webview/blob/master/plugin.xml#L68-L71
IMO providing a plugin that is just "ready to use" after installing would enhance the user experience and decrease the support issues/question.
Any thoughts, e.g., @erisu @NiklasMerz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] NiklasMerz commented on issue
#133: Enhance installation by inlining the configuration variables
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133#issuecomment-600561610
I thought about that too while writing the post. I definitely support it.
But we need to revise the docs anyway once the next cordova-ios major version is released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] erisu edited a comment on issue
#133: Enhance installation by inlining the configuration variables
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133#issuecomment-600582713
It is already there.
The reason I had it included in the steps is because some users it does not set. I think it was related to the config munging issue which I reverted the PR that caused the munging issue. Next major contains the revert..
https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/plugin.xml#L47-L52
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] timbru31 closed issue #133:
Enhance installation by inlining the configuration variables
Posted by GitBox <gi...@apache.org>.
timbru31 closed issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] NiklasMerz commented on issue
#133: Enhance installation by inlining the configuration variables
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133#issuecomment-600570377
For this change I would just do a PR and merge it. Once cordova-ios is released or about to release we need to check this plugins docs anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] erisu commented on issue #133:
Enhance installation by inlining the configuration variables
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133#issuecomment-600582713
It is already there.
The reason I had it included in the steps is because some users it does not set. I think it was related to the config munging issue which I reverted a PR change that caused it. Next major contains the revert..
https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/plugin.xml#L47-L52
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] timbru31 commented on issue #133:
Enhance installation by inlining the configuration variables
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133#issuecomment-600566752
General docs improvement is one of our bigger todos, that's true. Should we further discuss this on the mailing list? Not all members are subscribed to the GitHub issues noise. :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] timbru31 commented on issue #133:
Enhance installation by inlining the configuration variables
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #133: Enhance installation by inlining the configuration variables
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/133#issuecomment-600590846
Oh neat! Somehow I've overlooked these lines of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org