[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660301#comment-15660301 ] 

ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------

GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1128

    THRIFT-3873: fix compiler warnings on windows with VS2010

    Also changed VERSION to THRIFT_VERSION to avoid conflicts with third party or OS headers.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift defect/THRIFT-3873-take-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1128
    
----
commit a46d39010b52ab4aaae4ea1b5de477261999f1df
Author: James E. King, III <ji...@simplivity.com>
Date:   2016-07-08T22:04:21Z

    THRIFT-3873: fix compiler warnings on windows with VS2010; change VERSION to THRIFT_VERSION to avoid conflicts with third party or OS headers

----


> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
>                 Key: THRIFT-3873
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3873
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>         Environment: VS2010, Windows
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and found a number of compiler warnings that needed to be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)