You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2018/04/24 03:49:25 UTC
[kylin] 03/07: minor, fix exception swallow in CubeDesc.init()
This is an automated email from the ASF dual-hosted git repository.
shaofengshi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git
commit 9d88e47214b036b34dac38b12d549823cafdbefc
Author: Li Yang <li...@apache.org>
AuthorDate: Thu Apr 12 21:41:45 2018 +0800
minor, fix exception swallow in CubeDesc.init()
---
core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java | 6 +++---
core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java | 3 +--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java b/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
index 1db66e1..78c71b7 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
@@ -98,7 +98,7 @@ public class CubeDescManager {
cubeDesc.init(config);
} catch (Exception e) {
logger.warn("Broken cube desc " + cubeDesc.resourceName(), e);
- cubeDesc.addError(e.getMessage());
+ cubeDesc.addError(e.toString());
}
return cubeDesc;
}
@@ -193,7 +193,7 @@ public class CubeDescManager {
cubeDesc.init(config);
} catch (Exception e) {
logger.warn("Broken cube desc " + cubeDesc, e);
- cubeDesc.addError(e.getMessage());
+ cubeDesc.addError(e.toString());
}
postProcessCubeDesc(cubeDesc);
@@ -239,7 +239,7 @@ public class CubeDescManager {
desc.init(config);
} catch (Exception e) {
logger.warn("Broken cube desc " + desc, e);
- desc.addError(e.getMessage());
+ desc.addError(e.toString());
return desc;
}
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java b/core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
index 93c327d..77b808b 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
@@ -652,8 +652,7 @@ public class CubeDesc extends RootPersistentEntity implements IEngineAware {
Method initMeasureReferenceToColumnFamilyMethod = hbaseMappingAdapterClass.getMethod("initMeasureReferenceToColumnFamilyWithChecking", CubeDesc.class);
initMeasureReferenceToColumnFamilyMethod.invoke(null, this);
} catch (Exception e) {
- logger.error("Wrong configuration for kylin.metadata.hbasemapping-adapter: class "
- + hbaseMappingAdapterName + " not found. ");
+ throw new RuntimeException("Error during adapting hbase mapping", e);
}
} else {
if (hbaseMapping != null) {
--
To stop receiving notification emails like this one, please contact
shaofengshi@apache.org.