You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "scottf (via GitHub)" <gi...@apache.org> on 2025/08/15 16:25:58 UTC
[PR] [DOCS] List 3rd Party connector for NATS [flink]
scottf opened a new pull request, #26909:
URL: https://github.com/apache/flink/pull/26909
## What is the purpose of the change
Looking for a way to include the official NATS connector somewhere. It is developed by Synadia, the primary maintainers of NATS.
## Contribution Checklist
## Brief change log
*(for example:)*
- Edit of docs/content/docs/connectors/datastream/overview.md
## Verifying this change
Trivial documentation changed. Content/intention needs approval by a human.
## Does this pull request potentially affect one of the following parts:
Change does not affect any code.
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "scottf (via GitHub)" <gi...@apache.org>.
scottf commented on code in PR #26909:
URL: https://github.com/apache/flink/pull/26909#discussion_r2282840454
##########
docs/content/docs/connectors/datastream/overview.md:
##########
@@ -90,5 +90,8 @@ in order to enrich the primary datastream.
Flink offers an API for [Asynchronous I/O]({{< ref "docs/dev/datastream/operators/asyncio" >}})
to make it easier to do this kind of enrichment efficiently and robustly.
+### 3rd Party Connnectors
Review Comment:
License is Apache 2 https://github.com/synadia-io/flink-connector-nats/blob/main/LICENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26909:
URL: https://github.com/apache/flink/pull/26909#issuecomment-4395003289
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26909:
URL: https://github.com/apache/flink/pull/26909#discussion_r2322554827
##########
docs/content/docs/connectors/datastream/overview.md:
##########
@@ -90,5 +90,8 @@ in order to enrich the primary datastream.
Flink offers an API for [Asynchronous I/O]({{< ref "docs/dev/datastream/operators/asyncio" >}})
to make it easier to do this kind of enrichment efficiently and robustly.
+### 3rd Party Connnectors
Review Comment:
[https://flink.apache.org/how-to-contribute/contribute-documentation/#chinese-documentation-translation](https://flink.apache.org/how-to-contribute/contribute-documentation/#chinese-documentation-translation)
I suggest following the note :
NOTE: The Flink community is still in the process of translating Chinese documentations, some documents may not have been translated yet. If the document you are updating is not translated yet, you can just copy the English changes to the Chinese document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26909:
URL: https://github.com/apache/flink/pull/26909#issuecomment-5201540061
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "scottf (via GitHub)" <gi...@apache.org>.
scottf commented on code in PR #26909:
URL: https://github.com/apache/flink/pull/26909#discussion_r2282846512
##########
docs/content/docs/connectors/datastream/overview.md:
##########
@@ -90,5 +90,8 @@ in order to enrich the primary datastream.
Flink offers an API for [Asynchronous I/O]({{< ref "docs/dev/datastream/operators/asyncio" >}})
to make it easier to do this kind of enrichment efficiently and robustly.
+### 3rd Party Connnectors
Review Comment:
What is the process for getting the Chinese version created?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26909:
URL: https://github.com/apache/flink/pull/26909#discussion_r2282808184
##########
docs/content/docs/connectors/datastream/overview.md:
##########
@@ -90,5 +90,8 @@ in order to enrich the primary datastream.
Flink offers an API for [Asynchronous I/O]({{< ref "docs/dev/datastream/operators/asyncio" >}})
to make it easier to do this kind of enrichment efficiently and robustly.
+### 3rd Party Connnectors
Review Comment:
I think this should be agreed on the dev list and appropriate wording be added to indicate that these connectors are not supported by the Flink community. Also I notice that the license is not Apache.
If this is accepted you should include the Chinese version of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "scottf (via GitHub)" <gi...@apache.org>.
scottf commented on PR #26909:
URL: https://github.com/apache/flink/pull/26909#issuecomment-5203091330
Can this be approved without translation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "scottf (via GitHub)" <gi...@apache.org>.
scottf commented on PR #26909:
URL: https://github.com/apache/flink/pull/26909#issuecomment-4396263934
@davidradl If this isn't going to get approved you might as well close it. It seemed like a reasonable proposal and I requested translation as requested, but there has been nor response, so whatever you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26909:
URL: https://github.com/apache/flink/pull/26909#issuecomment-3192092203
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "809fa6b8a75ecc9c4b6eea5aaf4ba6e5403cc47c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "809fa6b8a75ecc9c4b6eea5aaf4ba6e5403cc47c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 809fa6b8a75ecc9c4b6eea5aaf4ba6e5403cc47c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26909:
URL: https://github.com/apache/flink/pull/26909#discussion_r2282808184
##########
docs/content/docs/connectors/datastream/overview.md:
##########
@@ -90,5 +90,8 @@ in order to enrich the primary datastream.
Flink offers an API for [Asynchronous I/O]({{< ref "docs/dev/datastream/operators/asyncio" >}})
to make it easier to do this kind of enrichment efficiently and robustly.
+### 3rd Party Connnectors
Review Comment:
I think this should be agreed on the dev list and appropriate wording be added to indicate that these connectors are not supported by the Flink community. Also I notice that the license is not Apache. Also there is not associated Jira in the title.
If this is accepted you should include the Chinese version of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "scottf (via GitHub)" <gi...@apache.org>.
scottf commented on PR #26909:
URL: https://github.com/apache/flink/pull/26909#issuecomment-3275099575
Added Jira for Chinese translation https://issues.apache.org/jira/browse/FLINK-38337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] List 3rd Party connector for NATS [flink]
Posted by "scottf (via GitHub)" <gi...@apache.org>.
scottf commented on PR #26909:
URL: https://github.com/apache/flink/pull/26909#issuecomment-3372305724
@davidradl I have requested the Chinese translation, the link is in the previous comment. It does not seem likely that this will happen or it will just take a long time. Is there any way to merge this PR without the translation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org