You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/08/02 02:45:51 UTC
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #479: [ISSUE #473]fix configuration property get error
xwm1992 commented on a change in pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#discussion_r680619750
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/ConfigurationWrapper.java
##########
@@ -80,7 +80,7 @@ public int getIntProp(String configKey, int defaultValue) {
if (StringUtils.isEmpty(configValue)) {
return defaultValue;
}
- Preconditions.checkState(StringUtils.isNumeric(configKey), String.format("%s error", configKey));
+ Preconditions.checkState(StringUtils.isNumeric(configValue), String.format("%s error", configKey));
Review comment:
here String.format is still configKey?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org