You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/09/10 17:45:44 UTC
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11409
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
[docs] Add "one client only" best practice for kudu-spark
Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
---
M docs/developing.adoc
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11409/1
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc@230
PS1, Line 230: To diagnose multiple `KuduClient` instances in a Spark job, look for signs in
: the logs of the master being overloaded by many `GetTableLocations` or
: `GetTabletLocations` requests coming from different clients, usually around the
: same time
> No, this issue is the problem with having multiple Kudu clients. Unfortunat
I see. My questions was more about how to diagnose that condition at the master's side. Is that something about warnings about slow method execution in the paths of client metadata RPCs, etc.? How do you tell that the master is overloaded with client metadata RPCs? Any specific, but easy to see signs?
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 18:29:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc@233
PS1, Line 233: prevalent
remove
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 17:49:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc@230
PS1, Line 230: To diagnose multiple `KuduClient` instances in a Spark job, look for signs in
: the logs of the master being overloaded by many `GetTableLocations` or
: `GetTabletLocations` requests coming from different clients, usually around the
: same time
Is there any manifestation of this issue visible from the operator's side? I.e., does it make sense to add a bit more details here?
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 18:00:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
Patch Set 2: Verified+1
No precommit needed for a docs-only change.
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 18:13:46 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc@230
PS1, Line 230: To diagnose multiple `KuduClient` instances in a Spark job, look for signs in
: the logs of the master being overloaded by many `GetTableLocations` or
: `GetTabletLocations` requests coming from different clients, usually around the
: same time
> I see. My questions was more about how to diagnose that condition at the m
There'll be a giant list of logs about those RPCs with about the same timestamp :), and possibly timeouts. It's obvious.
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 18:43:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11409
to look at the new patch set (#2).
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
[docs] Add "one client only" best practice for kudu-spark
Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
---
M docs/developing.adoc
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11409/2
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/11409/1/docs/developing.adoc@230
PS1, Line 230: To diagnose multiple `KuduClient` instances in a Spark job, look for signs in
: the logs of the master being overloaded by many `GetTableLocations` or
: `GetTabletLocations` requests coming from different clients, usually around the
: same time
> Is there any manifestation of this issue visible from the operator's side?
No, this issue is the problem with having multiple Kudu clients. Unfortunately, it's hard to see from the Spark side except as slowness and errors due to the master being overwhelmed by bursts of client metadata RPCs.
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 18:15:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add "one client only" best practice for kudu-spark
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11409 )
Change subject: [docs] Add "one client only" best practice for kudu-spark
......................................................................
[docs] Add "one client only" best practice for kudu-spark
Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Reviewed-on: http://gerrit.cloudera.org:8080/11409
Tested-by: Will Berkeley <wd...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/developing.adoc
1 file changed, 17 insertions(+), 0 deletions(-)
Approvals:
Will Berkeley: Verified
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaf369315b8627674ba64e6418d153568ded6fe8
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>