You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/09 14:42:51 UTC
[GitHub] [incubator-superset] rahul-rahul-sp opened a new issue #7839:
/shortner to use origin instead of host for request headers
rahul-rahul-sp opened a new issue #7839: /shortner to use origin instead of host for request headers
URL: https://github.com/apache/incubator-superset/issues/7839
https://github.com/apache/incubator-superset/blob/953e5c7a72acef34fc9447249c25db4e92ed5370/superset/views/core.py#L1011
currently our response uses "{scheme}://{request.headers[Host]}/r/{obj.id}".
should we use '{request.headers[origin]}/r/{obj.id}' instead, especially since this is a POST request?
any specific reason for using [Host] instead of [origin]?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org